mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.4k stars 1.12k forks source link

Mumble always resets jack audio connection when closing the audio setup panel #4064

Open fhars opened 4 years ago

fhars commented 4 years ago

Steps to Reproduce Steps to reproduce the behavior:

  1. Start jackd
  2. Start mumble
  3. Connect your microphone capture device to the mumble input.
  4. Open the audio input configuration dialog to adjust the speech recognition thresholds
  5. Click "OK"
  6. mumble disconnects from the microphone and connctes to the default system capture device.

Expected behavior

mumble shloud leave the jack connection graph unchanged.

Desktop (please complete the following information):

davidebeatrici commented 4 years ago

Thank you for reporting the issue.

It happens because every time settings are applied the audio input/output engine is reset.

We could save the connection(s) immediately before deleting the ports and restore them when the audio engine is started again.

Ideally we should implement a "soft restart" method though: if the backend is the same, we can just apply the settings without resetting it.