mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.36k stars 1.11k forks source link

Audio Control Panel #4190

Open streaps opened 4 years ago

streaps commented 4 years ago

Idea:

Create an Audio Control Panel (ACP) where users can change all important audio settings interactively. The ACP is accessible from the toolbar. It includes settings and visuals for:

DSP

It also might include (but less important): Audio I/O: Device, Delay, Jitter buffer Encoding / Network: Bitrate, Channels, Frame size

The purpose of the ACP is that users have quick access to these settings and get instant feedback (e.g. in Loopback mode). The layout of the ACP should also give users an idea of the audio flow and communicate clearly which processing units are active.

I also could replace the Audio Wizard from the Configure menu or could be integrated / combined with a improved Wizard.

As I understand it, this will mostly a UI design task, but I might underestimate the amount of code changes that would be needed.

The first goal is to create a raw visual prototype of the ACP.

If there is no fundamental resistance to the idea, I would start working on it. I see this as a low-priority task (for me and for the project).

streaps commented 4 years ago

Relevant issues: #4127, #4181, #3323, #4178, #4112, #2829, #4137

toby63 commented 4 years ago

Well I am sceptical on multiple points, see below.

But in general it can't hurt to have an extra toolbar, as long as its optional.

Regarding the points:

quick access

I don't really see much advantage in this, because right now you just click on the gear wheel and get directly into the options. Even the usecase in #4189 could be better solved with a hotkey or an element you can add to the toolbar (just like @trudnorx suggested it).

could replace the Audio Wizard

I don't see how a toolbar could replace that.

should also give users an idea of the audio flow

I think it will be the opposite, this control panel would be for advanced users rather than new and inexperienced users.

An alternative or additional idea would be to add some of the "missing" options to the regular audio options.

Krzmbrzl commented 4 years ago

I only see use in that for initially configuring the used microphone. This however is exactly what the audio wizard is for. Therefore I think if anything the missing parts could be integrated into that wizard but then again it'll probably make the wizard even more complicated and scare even more users... :thinking:

streaps commented 4 years ago

I guess trying to improve the usability of the Mumble desktop client is a lost cause.

Krzmbrzl commented 4 years ago

If you think this is important then please elaborate on why this is the case? Why do we need a separate panel for that instead of using the audio wizard? Why do we need to have this in the toolbar at a ll times?

trudnorx commented 4 years ago

Visuals for mic gain could be very useful, as well as a better mic gain option that really lets you do what you want. With the current amplification option, it seems you can't sound as loud as you want... an ACP which allows you to customize audio better, with more fine-grained tuning, would be very useful.

Another advantage is how this is interactive and applies changes immediately, but that could also be added to Settings.

While we're at it, an equalizer would be pretty good, too. Ideally one which allows the most fine-grained control -- not just a certain ranges of frequencies.

Krzmbrzl commented 4 years ago

Visuals for mic gain could be very useful

So you mean something like this just integrated into the UI?

All but the microphone level display sounds like something that could be equally well added to the existing settings page.

an ACP which allows you to customize audio better, with more fine-grained tuning, would be very useful.

Why an ACP instead of overhauling the settings page?

trudnorx commented 4 years ago

Why an ACP instead of overhauling the settings page?

Mix of both ideas would be best. Have it all in one place, but there should be a small, floatable window with all the audio settings which allows on-the-fly customization (immediately applied as you drag slider), isn't modal. Audio stuff then doesn't have to be in settings anymore.

Krzmbrzl commented 4 years ago

@streaps would this also work for you?

streaps commented 4 years ago

would this also work for you?

I'm not sure that what the differences between the thing I called ACP and the floatable window are.

I think an EQ is another issue.

(Maybe ideas like this are better suited for a new Mumble client (rewrite)?)

Krzmbrzl commented 4 years ago

I think an EQ is another issue.

I agree

I'm not sure that what the differences between the thing I called ACP and the floatable window are.

The key component for me is that this'd aim at improving the settings window and additionally providing an option to have that settings window as a floatable version as well. In contrast to that I understood your original request so that you wanted to create a completely new window that'd be exculsively used in the floating version.

streaps commented 4 years ago

I don't know how the best design / implementation would look like. Maybe the contents of the floating window can be put in Audio Input Settings. Maybe both version are not exactly the same. I would agree though that Audio Settings and floating ACP shouldn't be completely different.

Krzmbrzl commented 4 years ago

I think the floating UI should be able to be integrated into the settings page. So it should be designed in a way that allows for the UI to also be embedded in the settings page...