mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.41k stars 1.12k forks source link

Positional audio Plugin not showing up on Mac osx #5571

Closed Cardboard-Friend closed 2 years ago

Cardboard-Friend commented 2 years ago

The issue

When installing the latest version of mumble to use for positional audio in Minecraft the "Link" plugin is missing and positional audio doesn't work without it.

Mumble version

1.4.0

Mumble component

Client

OS

macOS

Additional information

No response

Krzmbrzl commented 2 years ago

Did you check the actual installation directory or did you only check whether the Link plugin was listed inside Mumble's settings?

Cardboard-Friend commented 2 years ago

I check both inside the mumble app and in the directory located in ~library/application support/mumble/mumble/plugins

Cardboard-Friend commented 2 years ago

I have also tried deleting all the program files and cache files and doing a fresh install of mumble but to no avail. and also downloaded the source code and manually copied the plugin data from the source code to the plugin folder but still nothing.

Krzmbrzl commented 2 years ago

I check both inside the mumble app and in the directory located in ~library/application support/mumble/mumble/plugins

And in none of these places was the plugin? Are there any other plugins that you found?

also downloaded the source code and manually copied the plugin data from the source code to the plugin folder but still nothing.

Which plugin folder?

Cardboard-Friend commented 2 years ago

There were no plugins in the plugin folder in the apps program files

Screenshot 2022-02-14 at 13 19 29 Screenshot 2022-02-14 at 13 20 03
Krzmbrzl commented 2 years ago

Hm weird :thinking:

And when you manually copied the plugin, where did you copy it to?

Cardboard-Friend commented 2 years ago

I manually copied it to the plugin folder in the apps program files

Cardboard-Friend commented 2 years ago

on older versions of mumble, the link plugin is shown in the app but doesn't work properly

Krzmbrzl commented 2 years ago

I manually copied it to the plugin folder in the apps program files

Try to instead open Mumble and the go to Settings > Plugins > Install (at the bottom) and select the plugin library that way. I wonder what that'll do :eyes:

Cardboard-Friend commented 2 years ago

which plugin library? in the source code for each plugin, there was a file and a separate folder

Screenshot 2022-02-14 at 14 13 30

(this is in the source code not my program files)

Cardboard-Friend commented 2 years ago

also might be worth noting but when using older versions of mumble paired with the Minecraft mumble link mod for positional audio the linking doesn't automatically update when switching servers, It only works initially on the first server join which doesn't work out when trying to use it on a minigame server on which you change servers each game. when testing on windows there is no issues on both old and new versions of mumble.

Krzmbrzl commented 2 years ago

The file that you manually color earlier. Should be called link.dylib

As to the server switching issue: that should probably be reported to the Minecraft Link plugin Deva.

Cardboard-Friend commented 2 years ago

the file doesnt seem to exist in the source code

Screenshot 2022-02-14 at 15 00 39

and trying to import the other files doesn't work, it results in an error message stating an invalid plugin format

Krzmbrzl commented 2 years ago

What did you copy before? You can't copy anything from the source code. You'll have to compile the source code and thst will produce the binary I mentioned

Cardboard-Friend commented 2 years ago

Is there not a way to make it work without compiling the source code? I'm not sure how to compile it correctly

Krzmbrzl commented 2 years ago

No it won't work without compiling. Normally it shouldn't be needed but for whatever reason it is. Maybe we have an issue with the script bundling our macOS binary (it might forget to include the plugin) 🤷

davidebeatrici commented 2 years ago

There were no plugins in the plugin folder in the apps program files Screenshot 2022-02-14 at 13 19 29 Screenshot 2022-02-14 at 13 20 03

That's the user data directory.

Krzmbrzl commented 2 years ago

Right - in there we wouldn't expect plugins anyway (not the default ones at least).

@davidebeatrici where should the default plugins be located on macOS? Are they also missing on your machine?

davidebeatrici commented 2 years ago

/Applications/Mumble.app/Contents/Plugins

Looks like the folder is empty in the release.

filleduchaos commented 2 years ago

Hello! I ran into this issue yesterday - I was able to just compile the plugin and put it in the correct folder myself, so that was alright, but also I could take a look at the macOS app bundler later this week/raise a PR

Krzmbrzl commented 2 years ago

I could take a look at the macOS app bundler later this week/raise a PR

That would be much appreciated! :heart: The bundler sits at https://github.com/mumble-voip/mumble/blob/master/macx/scripts/osxdist.py. Note that we suspect that the issue might not even be the bundler itself but rather the signing script as presented in https://github.com/mumble-voip/mumble/pull/5428 (it unpacks the bundle, signs the files and then repacks it again). We suspect that maybe during the repack we lost the plugins, but weren't able to dig into this more, as of yet.

Krzmbrzl commented 2 years ago

@filleduchaos have you gotten any insights into this yet?

Goofygooberyeah commented 2 years ago

Can confirm still an issue ;( not sure if this happens for every mac user or just a select few. Hope to see fixes soon!

blackxmat commented 2 years ago

HI,I am on MacOS Catalina and Today I installed mumble version 1.4.230 and the issue is here and I want to know if you have a another solution because i can't compile the plugin and also i wanted to know if you found any solution for this issue.

Krzmbrzl commented 2 years ago

No progress on this, so far

Krzmbrzl commented 2 years ago

I found and fixed the issue causing this behavior. Starting with the next Mumble 1.4 release (coming soon-ish) the Link plugin should be bundled with the macOS release again.