Logitech G-Keys broken in 1.5

[dot-gov]

Description

Support for Logitech G-Keys is broken in 1.5.x. Previously added shortcuts with g-keys would no longer function, and it's not possible to add new shortcuts with g-keys, because they're not recognized. It was working fine in 1.4.287 but after upgrading to 1.5.634 it's no longer working. I've also tried the first RC (1.5.517) and it's broken there as well.

Steps to reproduce

1. clear all mumble settings (ie. cleared %localappdata%\mumble, %appdata%\mumble, HKCU\Software\Mumble, and any mumble profile in logitech gaming software
2. install mumble
3. skip audio/certificate wizard
4. go to settings -> shortcut, check "enable gkey", click "ok" and restart mumble
5. open logitech gaming software, set the newly created mumble profile as "persistent"
6. open mumble settings -> shortcut, try to add a shortcut using one of the g keys

In 1.4 it recognizes g-keys just fine, but in 1.5 they're not recognized.

Mumble version

1.5.634

Mumble component

Client

OS

Windows

Reproducible?

Yes

Additional information

No response

Relevant log output

<X>2024-05-26 14:54:45.532 Loading settings from "C:/Users/Owner/AppData/Local/Mumble/Mumble/mumble_settings.json"
<W>2024-05-26 14:54:45.548 ASIO: No valid devices found, disabling
<W>2024-05-26 14:54:45.548 Theme: "Mumble"
<W>2024-05-26 14:54:45.548 Style: "Lite"
<W>2024-05-26 14:54:45.548 --> qss: ":themes/Default/Lite.qss"
<W>2024-05-26 14:54:45.548 Locale is "en_US" (System: "en_US")
<W>2024-05-26 14:54:45.720 Database SQLite: "3.43.2"
<W>2024-05-26 14:54:45.767 Updating application palette
<W>2024-05-26 14:54:46.205 QMetaObject::connectSlotsByName: No matching signal for on_qtvUsers_customContextMenuRequested(QPoint,bool)
<W>2024-05-26 14:54:46.205 QMetaObject::connectSlotsByName: No matching signal for on_muteCuePopup_triggered()
<W>2024-05-26 14:54:46.860 AudioInput: Opus encoder set for high quality speech
<W>2024-05-26 14:54:46.860 AudioInput: 40000 bits/s, 48000 hz, 480 sample
<W>2024-05-26 14:54:46.860 Public list disabled
<W>2024-05-26 14:54:45.782 XboxInput: using XInput DLL 'XInput1_4.dll'
<W>2024-05-26 14:54:45.782 XboxInput: using XInputGetStateEx() as querying function.
<W>2024-05-26 14:54:45.782 GKeyLibrary: Found ServerBinary with libLocation = "C:\Program Files\Logitech Gaming Software\SDK\G-key\x86\LogitechGkey.dll", len = 146
<W>2024-05-26 14:54:46.860 WASAPIInput: Latencies 101587 29025 => 100000
<W>2024-05-26 14:54:46.860 WASAPIOutput: Latencies 100000 26667 => 100000
<W>2024-05-26 14:54:46.876 WASAPIOutput: Output stream format 1
<W>2024-05-26 14:54:46.876 WASAPIOutput: Stream Latency 0 (2880)
<W>2024-05-26 14:54:46.876 WASAPIOutput: Periods 10000us 2666us (latency 0us)
<W>2024-05-26 14:54:46.876 WASAPIOutput: Buffer is 60000us (5)
<W>2024-05-26 14:54:46.879 AudioOutput: Initialized 2 channel 48000 hz mixer
<W>2024-05-26 14:54:46.879 WASAPIInput: Mic Stream format 1
<W>2024-05-26 14:54:46.879 WASAPIInput: Stream Latency 0 (984)
<W>2024-05-26 14:54:46.896 WASAPIInput: Echo Stream format 1
<W>2024-05-26 14:54:46.896 AudioInput: Initialized mixer for 2 channel 44100 hz mic and 2 channel 48000 hz echo
<W>2024-05-26 14:54:46.936 AudioInput: Using Speex as noise canceller
<W>2024-05-26 14:54:46.936 AudioInput: ECHO CANCELLER ACTIVE
<W>2024-05-26 14:55:10.663   OpenType support missing for "MS Shell Dlg 2", script 11
<W>2024-05-26 14:55:10.663   OpenType support missing for "Arial", script 11
<W>2024-05-26 14:55:10.667   OpenType support missing for "MS UI Gothic", script 11
<W>2024-05-26 14:55:10.667   OpenType support missing for "SimSun", script 11
<W>2024-05-26 14:55:10.677   OpenType support missing for "MS Shell Dlg 2", script 20
<W>2024-05-26 14:55:10.677   OpenType support missing for "Arial", script 20
<W>2024-05-26 14:55:10.677   OpenType support missing for "MS UI Gothic", script 20
<W>2024-05-26 14:55:10.677   OpenType support missing for "SimSun", script 20
<W>2024-05-26 14:55:10.677   OpenType support missing for "MS Shell Dlg 2", script 17
<W>2024-05-26 14:55:10.677   OpenType support missing for "Arial", script 17
<W>2024-05-26 14:55:10.677   OpenType support missing for "MS UI Gothic", script 17
<W>2024-05-26 14:55:10.683   OpenType support missing for "SimSun", script 17
<W>2024-05-26 14:55:10.863   OpenType support missing for "Segoe UI", script 20
<W>2024-05-26 14:55:10.867   OpenType support missing for "Microsoft YaHei UI", script 20
<W>2024-05-26 14:55:10.867   OpenType support missing for "Arial", script 20
<W>2024-05-26 14:55:10.867   OpenType support missing for "MS Shell Dlg 2", script 20
<W>2024-05-26 14:55:10.867   OpenType support missing for "MS UI Gothic", script 20
<W>2024-05-26 14:55:10.867   OpenType support missing for "SimSun", script 20

Screenshots

No response

[Krzmbrzl]

Does registering other shortcuts (e.g. a regular key on your keyboard) work?

[dot-gov]

Yes. Regular keys on my keyboard work (eg. F12), as the g-key, if I change the action to something like "F12" rather than the native g-key action.

[Hartmnt]

@Krzmbrzl ded91ed2c8d771d627d0c5d7c04bfcc79932af11 seems suspicious on paper

Edit: Wait sorry, this is the migration from 1.3.x to 1.4.x

[Krzmbrzl]

Yeah, this came to my mind as well, but I also think that this can't be responsible for the described behavior (it's only abou migrating settings after all)