mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.13k stars 1.09k forks source link

BUILD: Use correct type for num locks #6474

Closed Krzmbrzl closed 1 week ago

Krzmbrzl commented 1 week ago

The CRYPTO_num_locks function of OpenSSL returns an int, but we assigned the value to an unsigned int, leading to a compiler warning about a potential sign change. This is no issue on newer systems as apparently OpenSSL has removed these functions at some point and replaced them with a macro that evaluates to a numeric constant (1). However, on older systems such as CentOS 7, this function still seems to exist and there it actually matters that we are using a wrong type.

Fixes #6467

Checks

Krzmbrzl commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 1.5.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details