search

mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.
https://www.mumble.info
Other
6.43k stars 1.12k forks source link

FIX(client): Do not spam log when adjusting volume of clients without certificate #6486

Closed Hartmnt closed 4 months ago

Hartmnt commented 4 months ago

In #5776 the local volume adjustment sliders were moved into the user context menu. A log warning message appears, if you adjust the volume of a client without certificate. Due to a combination of Qt's buggy MouseWheel events and the oversight that volume changes to the DB happen much more frequently with that change, the log warning messages are spammed way to often now in that case.

This commit moves the log warning message explicitly into a separate slot on slider release. Note: We "lose" the warning message for other input methods that are not "releasing the slider", but given the fact that certificates are pretty prevalent now and dragging the slider is likely the most often used input method, this will likely affect a very little amount of users.

Fixes #6462

Krzmbrzl commented 4 months ago

💚 All backports created successfully

Status Branch Result
✅ 1.5.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details