FEAT(client): Add "View Description" context action to channels

mumble-voip / mumble

Mumble is an open-source, low-latency, high quality voice chat software.

https://www.mumble.info

Other

6.43k stars 1.12k forks source link

FEAT(client): Add "View Description" context action to channels #6526

Open dexgs opened 3 months ago

dexgs commented 3 months ago

Previously, channel descriptions could only be viewed as a pop-up which does not allow text selection/copying and doesn't allow you to scroll through descriptions to large to fit on your screen.

User comments already support this use case via the "View Comment" context menu action on users which opens their comment in a separate window.

This commit adds a "View Description" context menu action to channels which works the same way as the "View Comment" action.

Fixes #6525

Checks

[x] My commits follow the commit guidelines

Hartmnt commented 3 months ago

Hi, thanks for working on this :)

I have not reviewed your changes yet, but since this is adding and/or modifying existing UI please take a look at this document/checklist https://github.com/mumble-voip/mumble/blob/master/docs/dev/Accessibility.md

dexgs commented 3 months ago

The UI change is just a new context menu item on channels which works the same way as the existing "View Comment" menu action on users, so that should be fine.

I haven't set up translations for the new text yet.

dexgs commented 3 months ago

I've used a function pointer rather than the SLOT macro and updated the translation file to contain the new UI text.

Hartmnt commented 3 months ago

I've used a function pointer rather than the SLOT macro and updated the translation file to contain the new UI text.

To update the translation files, please call the updatetranslations.py script in our script folder. It automatically creates a new commit you can push. I would only recommend doing this, when this PR is done otherwise.

dexgs commented 3 months ago

Okay, PR is no longer a draft. I think it's ready to merge unless there are any more corrections.

dexgs commented 2 months ago

@Krzmbrzl @Hartmnt is there anything still blocking this PR?

Hartmnt commented 2 months ago

@dexgs No, not from your point of view :) We struggle a little with time and CI stuff which has delayed some things. But this PR is still on the TODO list.

davidebeatrici commented 2 months ago

@dexgs Please rebase this against master and CI should succeed.

dexgs commented 2 months ago

@dexgs Please rebase this against master and CI should succeed.

done