search

mumble-voip / mumo

Mumble Moderator framework simplifying development of plugins that connect to Mumble servers via Ice. (handles basic ICE connectivity, contains basic module loading and message multiplexing)
53 stars 29 forks source link

fix: rename Murmur to MumbleServer #25

Closed z-bsod closed 1 year ago

z-bsod commented 1 year ago

Apparently due to internal renaming in mumble-server the class generated by ICE isn't called Murmur anymore.

Renaming Murmur to MumbleServer seems to fix this issue for me.

this should also fix #23, I think.

Hartmnt commented 1 year ago

Note: This change will break compatibility with Mumble 1.4.x and below. 1.5.x is not fully released yet, but I'm not saying that this means this should not be merged.

z-bsod commented 1 year ago

Good catch! Haven't though about this and I think it is generally a good idea to support older versions of mumble as well if it isn't a big hassle. With the small change in 41fb0cb44dc30b55db260bea2ec72e4645978b75 it should work with 1.4 as well.

Kissaki commented 1 year ago

Thank you very much

I'll merge it without personally testing it. It looks plausible to me, and with the interactions we saw here, I assume and trust it works fine :)