search

mumixam / weechat-twitch

Checks status of streams using twitch api
31 stars 9 forks source link

Merge weechat-scripts version #20

Closed stacyharper closed 1 month ago

stacyharper commented 1 month ago

While backporting the eval expression to weechat-scripts:

https://github.com/weechat/scripts/pull/555

I did notice that both version have diverged slightly.

This MR merge back it upstream here.

stacyharper commented 1 month ago

I know that this merge make the release flags to be a bit wrong. But both now live in two different dystopics, so I don't really know what is the best thing to do.

mumixam commented 1 month ago

sorry the delay. is there any reason you changed the tag line from tags = dict([s.split('=',1) for s in mp['tags'].split(';')]) to tags = dict([s.split('=') for s in mp['tags'].split(';')])

I'm not 100% sure why I did it like that in the 1st place honestly. codebase is pretty old at this point and I dont spend much time on twitch chat these days.

stacyharper commented 1 month ago

iirc because this was causing warning or deprecated message in the weechat log buffer. But I'm not sure anymore

mumixam commented 1 month ago

I believe those are unrelated as i've never seen them myself. what version of python are you using

/debug libs will tell you

Python 3.12.3 (main, Apr 23 2024, 09:16:07) [GCC 13.2.1 20240417] on linux
>>> 'T.e.s.t.i.n.g'.split('.',1)
['T', 'e.s.t.i.n.g']
stacyharper commented 1 month ago

Okay, dunno where I saw this :S

mumixam commented 1 month ago

ok i found out the reason i added the maxsplit of 1.

this was to fix issues when the chat message contained "="

added in this commit https://github.com/mumixam/weechat-twitch/commit/3c54a7b4e91a3c0ecf438740a38ff0add1b75bb5