mumoshu / play2-memcached

A memcached plugin for Play 2.x
Other
161 stars 66 forks source link

Update Spy to 2.8.12 #17

Closed daschl closed 11 years ago

daschl commented 11 years ago

Hi,

spy is currently at 2.8.12, there have been some bugfixes around ketama hashing as well - do you mind updating the dependency? Should be straightforward from the plugins perspective!

mumoshu commented 11 years ago

Hi,

Thank you for your information :)

I have just released play2-memcached: 0.3.0.1 for Play 2.1 with Spy 2.8.12 0.2.4.1 for Play 2.0.x with Spy 2.8.12

Enalmada commented 11 years ago

When using the new version 0.3.0.1 I get "Auth failure" errors and it won't connect (to Couchbase v2.0 memcache bucket with password). Going back to the prior version 0.3.0 works again.

[error] memcached - Error: Auth failure [warn] memcached - Discarding partially completed op: Cmd: 10 Opaque: 129 [warn] memcached - Closing, and reopening {QA sa=localhost/127.0.0.1:11211, #Rop s=0, #Wops=0, #iq=0, topRop=null, topWop=null, toWrite=0, interested=8}, attempt 9.

mumoshu commented 11 years ago

Thanks for your report.

I have just tested spymemcached one-by-one from 2.8.4 to 2.8.12. It seems that you get the 'Auth failure' errors since 2.8.10.

mumoshu commented 11 years ago

I have filed an issue for spymemcached here:

https://code.google.com/p/spymemcached/issues/detail?id=272&thanks=272&ts=1364702110

mumoshu commented 11 years ago

@Enalmada Would you mind providing the maintainer of spymemcached about your environment here? Thanks!

daschl commented 11 years ago

Hey guys,

I'm currently also in charge for spy. It would be great if I can get your setup so I can try to reproduce! Until then, lets stick with 2.8.9 I guess - not so much has changed for this purpose here.

Enalmada commented 11 years ago

I put my environment details into the ticket. Let me know if there is any other details that could help!

"I have the same problem reported by original ticket opener. Server framework is PlayFramework 2.1 connecting to memcached server using the https://github.com/mumoshu/play2-memcached module. Everything worked fine until play2-memcached module upgraded to spymemcached 2.8.10. Development environment is windows 7, Java 7_15, Couchbase 2.0. Authentication issue happens on both their couchbase bucket and memcached bucket. Let me know if there is anything else I can provide that could help."

daschl commented 11 years ago

Okay guys, please use port 11210 if you use SASL authentication! .. 11211 is moxi in this case for the default bucket which is auth-less. I'm not sure why it did work before, but can you please try to use port 11210 with username and password of the bucket and give it the list of nodes you want to work with.

If you need assistance on moxi setup (and maybe it's an issue there), we can investigate further!

mumoshu commented 11 years ago

@daschl Thanks for the info! I have changed the port to 11210 and it did work!

However, I wonder if 11211 is really just for the default bucket?

In the documentation of moxi:

The gateway moxi also has a special responsibility to handle any buckets that need SASL authentication. That is, a client can use the binary memcached protocol to connect to the gateway moxi and use SASL authentication (which is part of the binary memcached protocol) to associate the client's connection with a different bucket.

According to the documentation, If the moxi bound to port 11211 is the gateway moxi which is referred here, I guess that 11211 should also be able to serve buckets with SASL. Probably something wrong with documentation, or am I missing something?

daschl commented 11 years ago

Hi mumoshu,

yes you are right in this case. I'm still investigating why moxi has issues with our recent changes made to spymemcached, I'll update you all on the issue. The one presented by me is a quick fix until we figure out the real problem (because when going to 11210 you obviously loose all the moxi goodness)

Thanks, Michael

anfuerer commented 11 years ago

We are using 0.3.0.1 for Play 2.1 with Spy 2.8.12 on Heroku. Changing to Port 11210 (mc7.ec2.northscale.net/10.84.85.93:11210) does not work for us. We are still getting authentication failures.

We would like to revert back to a version with Spy 2.8.9. As far as I see the github master is already using 2.8.9. However, I can't find a plugin snapshot build on sonatype? Isn't there one available?

mumoshu commented 11 years ago

@anfuerer

Hi!

Anyway, I have just released 0.3.0.2 with spymemcached reverted to 2.8.9. I guess it will be synced and avaiable via Maven Central in few hours. Would you please try with it?

For authentication failures with spy 2.8.12 and CouchDB, unfortunately I don't have much insights../ :( But it will be very helpful to provide more information about your environment (like CouchDB version, EC2 configuration, etc) to reproduce your problem in spymemcached's issue here.

Thanks

daschl commented 11 years ago

Hi everyone,

we'll release a new version this week where the code change gets reverted. This will probably be a 2.9.0 version because of some nice additions (but no API changes). I'll let you know once it is published!

mumoshu commented 11 years ago

@daschl

I'm really looking forward for the new version of spymemcached. Thanks for the information!

anfuerer commented 11 years ago

@mumoshu

I verified 0.3.0.2. Works as expected. Thanks a lot!!

amiklosi commented 11 years ago

@mumoshu would you mind releasing a 0.2.4.2 with the same fix for Play 2.0?

mumoshu commented 11 years ago

@amiklosi I have just release 0.2.4.2 (which is for play.2.0) with spymemcached reverted 2.8.9.

Thanks!

daschl commented 11 years ago

FYI 2.9 is due next week that solves this issue introduced in 2.8.10

daschl commented 11 years ago

We shipped SPY 2.9.0 and you can get it directly from maven central!

note that the groupid has changed from "spy" to "net.spy" so that we follow the maven central standard!

mumoshu commented 11 years ago

@daschl @Enalmada @amiklosi @anfuerer

I have just released 0.2.4.3 and 0.3.0.3 with spymemcached 2.9.0. And FYI, connections to SASL buckets with port 11211 seem to work for me! Would you also check it out?

Thanks!

Enalmada commented 11 years ago

Seems to work fine for couchbase. Sorry for the delay. Thanks very much mumoshu for this great plugin.

anfuerer commented 11 years ago

@mumoshu I verfied 0.3.0.3 with spymemcached on heroku using memcachier. works as expected. thanks a lot!

mumoshu commented 11 years ago

Thank you for your help, @Enalmada @anfuerer @amiklosi @daschl ! I'm closing this issue for now. Feel free to create a new issue or to reopen this one once you have encountered further issues!