search

mumoshu / play2-memcached

A memcached plugin for Play 2.x
Other
161 stars 66 forks source link

Exceptions from get #30

Closed adamrabung closed 7 years ago

adamrabung commented 10 years ago

Currently, a None from .get means both "cache miss" and "memcached down/connection issues". I'd like to distinguish between these two cases. This code introduces a new config property ("memcached.throwExceptionFromGetOnError") that allows the original Exception escape to the calling code.

NikolaySl commented 7 years ago

Very useful feature. @mumoshu As I can see the build is failing because of License issue with oracle jdk6. Are you going to introduce this feature?

mumoshu commented 7 years ago

@adamrabung @NikolaySl Hi - whoa, this is 2-years old PR now. Sorry for being super delayed in response. I've been busy these years and therefore had no chance to take a look into this. Anyway, your change looks good to me. Regarding the issue with oracle jdk6, I suppose it is already dropped from our build matrix. I'm going to resolve conflict/merge this to see if it actually passes today and make fixes if necessary to adapt the cool enhancement you've made. Thank you very much for your interest and the contribution 🍺

mkurz commented 7 years ago

I implemented this in #52

mkurz commented 7 years ago

@mumoshu This can be closed.

mumoshu commented 7 years ago

Closing this in favor of #52. @mkurz Thank you very much for your support 👍