search

mumoshu / play2-memcached

A memcached plugin for Play 2.x
Other
161 stars 66 forks source link

Remove global state #55

Closed mkurz closed 7 years ago

mkurz commented 7 years ago

Remove global state by removing a reference to Play.current inside CustomSerializing (you don't see the old class in the diff because it was a symlink before). Instead we inject Environment and pass its classloader to CustomSerializing. See https://www.playframework.com/documentation/2.6.x/Highlights26#Global-State-Free-Applications

Review is probably done best on per-commit basis so it's easier for your to comprehend my thoughts.

@mumoshu Can you please merge and cut a new release? I prepared everything, it should be easy for you. We really need a new version asap, thanks!

mumoshu commented 7 years ago

@mkurz Thank you very much for your efforts. I've read over all the your works from the PR description and code changes, commit messages. Everything looks great :heart:

I'll try to release the new version asap.

mumoshu commented 7 years ago

@mkurz FYI, I have just released 0.9.1.

mkurz commented 7 years ago

@mumoshu Great, thanks!