Open jamesd8 opened 11 years ago
Hi,
Thanks for your report. I will check it but it will take some time as I don't own any Windows PCs.
Btw, would you please tell me which version of JDK you are using, 1.6 or 1.7?
I'm running 64-bit Sun Java 1.6.0_32-b05. Let me know if I can help with some tests or what have you.
It might also be that the windows command is "tsc.cmd", not "tsc". In the command window it is ok to type just tsc but all bets are off when calling from the Scala ProcessBuilder. Now that I think of it, that actually seems like the more likely culprit than the path. Would it be possible to try both "tsc" and "tsc.cmd" and only throw the exception if both fail?
Hi,
I have fixed the plugin to use "cmd /C tsc" when ran on Windows, which invokes "tcs.cmd" as you mentioned. The fix is available in 0.1.2-SNAPSHOT. Would you please try that and report if you find any problem?
I am running play 2.0.3 on Windows 7 64 bit.
I installed everything per your instructions and put a test .ts file in assets/javascripts. When I reload the page the plugin tries to compile it but fails on the external call to tsc. I checked and tsc is definitely in the system path (and runs from the same command window that I ran play from), so my best guess is that the scala ProcessBuilder doesn't use the system path by default.
If my guess is correct, then it might be useful to allow the specification of a tsc path in some appropriate config file.
If I'm doing something wrong, I'd love to know what it is. The call stack of the failure is:
Thanks!