mumoshu / terraform-provider-eksctl

Manage AWS EKS clusters using Terraform and eksctl
Apache License 2.0
236 stars 44 forks source link

Short-Circuit Manifest Application / Pod Health Checks if not provided #3

Closed MMartyn closed 4 years ago

MMartyn commented 4 years ago

If no manifests are provided we could skip the attempt to apply them. Same for the pod health checks.

MMartyn commented 4 years ago

Possibly something like so:

https://github.com/mumoshu/terraform-provider-eksctl/blob/master/pkg/resource/cluster/cluster.go#L40

if len(cluster.CheckPodsReadinessConfigs) == 0 {
  return nil
}

https://github.com/mumoshu/terraform-provider-eksctl/blob/master/pkg/resource/cluster/cluster.go#L93

if len(cluster.Manifests) == 0 {
  return nil
}
mumoshu commented 4 years ago

@MMartyn Thanks! That makes senes. It's fixed in master now.