search

mumoshu / terraform-provider-eksctl

Manage AWS EKS clusters using Terraform and eksctl
Apache License 2.0
234 stars 44 forks source link

Fix harmless Fargate error checking #41

Closed TiagoJMartins closed 3 years ago

TiagoJMartins commented 3 years ago

Closes #40.

I've run across a slightly different error than the one that's currently being checked on the harmlessFargateProfileCreationErrors slice.

In the mentioned Issue, I've suggested something like checking with strings.Contains but I feel like that could ignore errors that aren't harmless in some cases (not quite sure though).

With this in mind, I've decided to simply add my variation of the error to the slice itself, this fixed my issue and now it works correctly.

I took the opportunity to fix a simple grammar typo as well if you don't mind.

Let me know if this needs to be changed in any way or if it simply isn't the best approach for it.

TiagoJMartins commented 3 years ago

Any chance you can take a look at this @mumoshu?

mumoshu commented 3 years ago

@TiagoJMartins Thanks for the PR! I'll review this today.