search

mumoshu / terraform-provider-helmfile

Deploy Helmfile releases from Terraform
126 stars 20 forks source link

Set kubeconfig to sensitive value #45

Closed ArchdukeNavaron closed 3 years ago

ArchdukeNavaron commented 3 years ago

Because the kubeconfig file contains sensitive data (tokens or private keys) which should not be printed I added the sensitive flag to these resource objects. Currently the whole file is printed in the diff.

ArchdukeNavaron commented 3 years ago

I tried to template the content directly into this resource object which didn't work. I had to use a path to the config file. The path to the file is obviously not sensitive. I will therefore close this pull request.

mumoshu commented 3 years ago

@ArchdukeNavaron Thanks for trying! I should have named it kubeconfig_path so that there should have been any misconception. Fortunately we're still pre 1.0 so it should be a good change before we go 1.0 :)