search

mumu-lhl / Ciyue

A simple mdict dictionary with Android support
https://f-droid.org/packages/org.eu.mumulhl.ciyue/
MIT License
241 stars 7 forks source link

Possibility of removing external storage permission #61

Open s12f opened 1 week ago

s12f commented 1 week ago

I had read https://github.com/mumu-lhl/Ciyue/issues/8 https://gitlab.com/fdroid/fdroiddata/-/merge_requests/15597#note_2056149689 https://github.com/mumu-lhl/Ciyue?tab=readme-ov-file#read_external_storage--manage_external_storage-manage-external-storage

In my understanding, this limitation is caused by the adding dictionary design that always select a mdx file first then read other related resources, if we add the support of loading a directory(included all resources, using SAF) to add a dictionary(or multiple dictionaries), is it possible to remove the external storage permission requirement ?

I think that is how Eudic works, it doesn't require the external storage permission.

Whatever, thank you for your great work :>

mumu-lhl commented 3 days ago

After rethinking it, it is possible, but the implementation is incompatible with the existing code, so it will be implemented in v1.0.0.