mumuki / mumuki-domain

💡 Mumuki's domain model
GNU Affero General Public License v3.0
1 stars 0 forks source link

Use submitted_at on activity date filters again #229

Closed felipecalvo closed 3 years ago

felipecalvo commented 3 years ago

:dart: Goal

Revert https://github.com/mumuki/mumuki-domain/pull/223.

:memo: Details

While that pull request's "Future Work" mentioned we should revert it three months after its implementation, we decided we'll instead make sure no assignments with submitted_at: nil remain in the database (for assignments where the status is not pending, which means an actual submission was made). This is a cleaner approach as all data is kept in a consistent state, instead of behavior that depends on the row's date.