search

mumuki / mumukit-login

Omniauth-based login library for Mumuki Platform
MIT License
1 stars 0 forks source link

Issue#30 parameterize ssl certificate #31

Closed julian-berbel closed 6 years ago

julian-berbel commented 6 years ago

Fixes #30.

julian-berbel commented 6 years ago

I thought this would be right but there's something that doesn't make much sense, which is, if disable_ssl_verification is set to true but there's no ssl_certificate set, the login is not failing and it's doing it either way...

flbulgarelli commented 6 years ago

I thought this would be right but there's something that doesn't make much sense, which is, if disable_ssl_verification is set to true but there's no ssl_certificate set, the login is not failing and it's doing it either way...

:thinking: It does actually make sense to me: if there is no ssl verification, you should not fail even if there is no ssl_certificate