search

mumuki / rouge

A pure-ruby code highlighter that is compatible with pygments http://rouge.jneen.net/
Other
0 stars 0 forks source link

Check highlighters state #1

Open Charlyzzz opened 7 years ago

Charlyzzz commented 7 years ago

Checkout either wollok-lexer or gobstones-lexer and rack it up, hit :9292/$lang_name and let me know what you think @aguspina @faloi @fedescarpa You can play with different themes :9292/$lang_name?theme=$theme_name

Themes:

base16 colorful github gruvbox molokai monokai monokai_sublime thankful_eyes tulip

faloi commented 7 years ago

I won't have access to a computer until February, so no way I can try this one by myself. Can you provide a few screenshots instead?

flbulgarelli commented 7 years ago

@aguspina bump

Charlyzzz commented 7 years ago

In 20 min or so I can post the images

flbulgarelli commented 7 years ago

Its important to give feedback to this issue so that we can go on with using this fork.

@Charlyzzz please provide the images @faloi requested so he can check it too

Charlyzzz commented 7 years ago

Gobstones and Wollok albums

flbulgarelli commented 7 years ago

Except by the fact that some Gobstones samples are a bit contrived - particularly the passed.Asset thing, I am pretty sure that does not even compile - and that comments in gobstones are only C-style, it looks good to me.

Could you please fix those issues and create the appropriate pull requests it to the original rouge repo?

flbulgarelli commented 7 years ago

Also, on the meanwhile, use this fork in laboratory and bibliotheca

Charlyzzz commented 7 years ago

Everything was taken from [this repo] (https://github.com/gobstones/pygobstones-lang)

flbulgarelli commented 7 years ago

Everything was taken from [this repo] (https://github.com/gobstones/pygobstones-lang)

Ok. In that case @faloi please confirm what to do.

faloi commented 7 years ago

Gobstones is ok, but XGobstones is not, the syntax you used is a previous version. Please check Flavia's email for the latest one.

Another thing: if you check the examples from Flavia, you'll see that different colors are used for function and procedure definition (I think light blue) and the rest of the keywords like repeat, if, etc (purple or something alike). Can we maintain that difference?

@flbulgarelli how do we choose themes in laboratory? It would be really nice to use the same colors across the editor, the description and Gobstones web.

flbulgarelli commented 7 years ago

We are always using the Github theme

flbulgarelli commented 7 years ago

@Charlyzzz see these updated samples

Charlyzzz commented 7 years ago

@faloi Keep in mind that rouge has two parts: lexers (what I'm doing) and themes. Every lexeme has a color property inside the theme. Anyway, I'll try to tweak a thing or two based on the email Flavia sent me