Closed dependabot[bot] closed 2 years ago
@Wodann the tests of this PR fail because we include the version of cbindgen in the generated file. I think we can also simply remove this, I don't know what the purpose is of having that in there other than that you can reproduce it later. Removing it would simplify these upgrades, as well as remove a hard constraint in the Cargo.toml. WDYT?
@Wodann the tests of this PR fail because we include the version of cbindgen in the generated file. I think we can also simply remove this, I don't know what the purpose is of having that in there other than that you can reproduce it later. Removing it would simplify these upgrades, as well as remove a hard constraint in the Cargo.toml. WDYT?
The one value of having the version listed is that you can reproduce issues with a specific version of cbindgen. If you don't think that's worth it, feel free to leave it out during generation 🙂
Cool, I'll remove it then. These upgrades should be very safe because we have a test that validates the output stays the same.
Merging #414 (08f979a) into main (7b54057) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 83.81% 83.81%
=======================================
Files 273 273
Lines 16179 16179
=======================================
Hits 13560 13560
Misses 2619 2619
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7b54057...08f979a. Read the comment docs.
Updates the requirements on cbindgen to permit the latest version.
Release notes
Sourced from cbindgen's releases.
Changelog
Sourced from cbindgen's changelog.
... (truncated)
Commits
f43ccfc
Bump version.116a18c
tests: Add a test for struct constants going through typedefs.fc98189
bindings: Peel through typedefs for struct constant generation.4b30c56
Rustfmt recent changes.3d06ae1
Version bump.80da604
bitflags: Be explicit in binary operators and such.9855f90
Version bump.5da3715
constant: Add support for unary negation.021d09d
bitflags: Make more operations constexpr.2e2c87e
Fix changelog typo.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)