search

mun-lang / mun

Source code for the Mun language and runtime.
https://mun-lang.org
Other
1.87k stars 73 forks source link

feat: add M1 support #444

Closed Wodann closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #444 (4ca4488) into main (3f7b316) will decrease coverage by 0.04%. The diff coverage is 53.84%.

:exclamation: Current head 4ca4488 differs from pull request most recent head f624888. Consider uploading reports for the commit f624888 to get more accurate results

@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
- Coverage   79.35%   79.30%   -0.05%     
==========================================
  Files         255      256       +1     
  Lines       13464    13483      +19     
==========================================
+ Hits        10684    10693       +9     
- Misses       2780     2790      +10
Impacted Files Coverage Δ
crates/mun_target/src/spec.rs 86.36% <ø> (ø)
crates/mun_target/src/spec/aarch64_apple_darwin.rs 0.00% <0.00%> (ø)
crates/mun_codegen/src/assembly.rs 85.10% <40.00%> (-5.37%) :arrow_down:
crates/mun_runtime/src/lib.rs 77.29% <84.61%> (+0.20%) :arrow_up:
crates/mun_target/src/spec/apple_base.rs 56.66% <100.00%> (+1.49%) :arrow_up:
crates/mun_hir/src/ty/infer/type_variable.rs 81.25% <0.00%> (+0.89%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

baszalmstra commented 2 years ago

Im looking into the disk space issue.

baszalmstra commented 2 years ago

Our build is using more than 14gb. Do you think we can remove some dependencies? Or maybe we can not build the dependencies for the benchmarks? We are not running them anyway in CI and cargo check still checks them (I think).

Wodann commented 2 years ago

Our build is using more than 14gb. Do you think we can remove some dependencies? Or maybe we can not build the dependencies for the benchmarks? We are not running them anyway in CI and cargo check still checks them (I think).

I actually started looking through our dependencies with tools, in order to remove them. The tricky part is that our inkwell dependency prohibits us from using any of the normal tooling, as it cannot resolve its version naming.