Closed baszalmstra closed 1 year ago
Merging #495 (4a9ed64) into main (a3025a7) will decrease coverage by
0.07%
. The diff coverage is52.38%
.
@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 87.17% 87.09% -0.08%
==========================================
Files 275 274 -1
Lines 31046 31082 +36
==========================================
+ Hits 27064 27071 +7
- Misses 3982 4011 +29
Impacted Files | Coverage Δ | |
---|---|---|
crates/mun_target/src/spec.rs | 89.74% <ø> (-0.26%) |
:arrow_down: |
crates/mun_target/src/spec/aarch64_apple_darwin.rs | 0.00% <0.00%> (ø) |
|
crates/mun_target/src/spec/aarch64_apple_ios.rs | 0.00% <0.00%> (ø) |
|
...rates/mun_target/src/spec/aarch64_apple_ios_sim.rs | 0.00% <0.00%> (ø) |
|
crates/mun_target/src/spec/x86_64_apple_ios.rs | 0.00% <0.00%> (ø) |
|
crates/mun_target/src/spec/apple_base.rs | 53.47% <51.45%> (-5.36%) |
:arrow_down: |
crates/mun_codegen/src/linker.rs | 88.70% <100.00%> (+2.21%) |
:arrow_up: |
crates/mun_target/src/spec/x86_64_apple_darwin.rs | 100.00% <100.00%> (ø) |
|
...ates/mun_target/src/spec/x86_64_pc_windows_msvc.rs | 100.00% <100.00%> (ø) |
|
...es/mun_target/src/spec/x86_64_unknown_linux_gnu.rs | 100.00% <100.00%> (ø) |
|
... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thanks I modified the changelog.
To get this to work on macOS I had to refactor the apple targets again a little bit. I think they are actually simpler now. It works on my old x86_64 MacBook but I don't have access to an M1. Would you be able to run the tests locally @Wodann ?
To get this to work on macOS I had to refactor the apple targets again a little bit. I think they are actually simpler now. It works on my old x86_64 MacBook but I don't have access to an M1. Would you be able to run the tests locally @Wodann ?
Yup, I'll checkout your branch and run it 🙂
I released lld-rs for LLD 14 and updated the dependency in this branch. If CI succeeds we can merge.
Bump LLVM from 13 to 14.