mun-lang / mun

Source code for the Mun language and runtime.
https://mun-lang.org
Other
1.81k stars 72 forks source link

fix: don't perform invalid reference cast #554

Closed wackbyte closed 5 months ago

wackbyte commented 5 months ago

Replaces it with a raw pointer. Avoids possible Undefined Behavior.

Stripped-down example of how the current code fails in Miri: playground Equivalent using the implementation from this PR: playground

codecov[bot] commented 5 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7a99ba6) 87.30% compared to head (bff060e) 87.25%. Report is 1 commits behind head on main.

Files Patch % Lines
crates/mun_runtime/src/lib.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #554 +/- ## ========================================== - Coverage 87.30% 87.25% -0.06% ========================================== Files 276 276 Lines 31970 31966 -4 ========================================== - Hits 27912 27891 -21 - Misses 4058 4075 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.