mundschenk-at / php-typography

A PHP library for improving your web typography.
GNU General Public License v2.0
68 stars 6 forks source link

Maybe not working with html heading tags? #153

Closed Lennso closed 1 year ago

Lennso commented 2 years ago

See this first: https://github.com/nystudio107/craft-typogrify/issues/78

I use typogrify plugin for craft which uses php-typography: {{ entry.editor | typogrify }}

My typogrify.php config:

"set_hyphenation" => true,
"set_hyphenate_headings" => true

My (german-text) html output:

<div>
<h6>Krank werden kann Jede:r</h6>
<h2>Warum brauche ich eine private Krankentagegeldversicherung?</h2>
<p>Die Krankentagegeld­&shy;versicherung schützt Sie gegen den Verdienstausfall bei Arbeits­&shy;unfähigkeit, soweit diese auf einer Krankheit oder einem Unfall beruht. Die Versicherung zahlt ab vereinbartem </p>
</div>

Hyphenation for my p-element is working, but not for the headings. Could it have something to do with this package?

mundschenk-at commented 2 years ago

I'd need your full configuration to be sure, but most likely you have either enabled dewidowing or are skipping the contents of <h1> and <h2>.

mundschenk-at commented 2 years ago

Is this still relevant, @Lennso?

mundschenk-at commented 1 year ago

Apparently not.