mundschenk-at / wp-typography

Improve your WordPress micro typography.
https://code.mundschenk.at/wp-typography/
Other
22 stars 3 forks source link

Prevent HTML tags in <title> #246

Closed mundschenk-at closed 5 years ago

mundschenk-at commented 5 years ago

Processing the title parts should not result in HTML tags (<span class="caps"> etc.) being added, as ´` only allows plain text content.</p> <p>Reported <a rel="noreferrer nofollow" target="_blank" href="https://wordpress.org/support/topic/title-with-tags/#post-11531777">in the WordPress forums</a>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mundschenk-at"><img src="https://avatars.githubusercontent.com/u/6943905?v=4" />mundschenk-at</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p><strike>Actually, it's a bug in <a href="https://github.com/sybrew/the-seo-framework">The SEO Framework</a>.</strike></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/mundschenk-at"><img src="https://avatars.githubusercontent.com/u/6943905?v=4" />mundschenk-at</a> commented <strong> 5 years ago</strong> </div> <div class="markdown-body"> <p>While the specific issue stems from an incompatibility with what The SEO Framework does, @sybrew's analysis in <a href="https://github.com/sybrew/the-seo-framework/issues/436">https://github.com/sybrew/the-seo-framework/issues/436</a> is not completely wrong: Several filter hooks used by wp-Typography since "forever" don't expect added HTML markup (or at least it's not clear that users of the relevant functions should expect to handle HTML in the returned values).</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>