search

mundschenk-at / wp-typography

Improve your WordPress micro typography.
https://code.mundschenk.at/wp-typography/
Other
22 stars 3 forks source link

Default styles #315

Open theamnesic opened 1 year ago

theamnesic commented 1 year ago

Hi @mundschenk-at !

I just noticed that you add default-styles.css by default in the wp_head since 5.9, even if Include styling for CSS hooks. option is unchecked.

Is it possible not to include it, by a hook or in plugin settings?

Thanks!

mundschenk-at commented 1 year ago

I am not sure what you mean? default-styles.css is only used to load the default styles option if you reset your settings.

The only stylesheet logic in the plugin adds an inline style (and not default-styles.css directly) when enabling the `Include styling for CSS hooks." option. That's been unchanged since 2019.

theamnesic commented 1 year ago

Sorry, I wanted to say the content of default-styles.css. So I think It's a bug.

My settings :

Capture d’écran 2023-02-07 à 11 04 51

But, the inline default-styles.css content in my header :

Capture d’écran 2023-02-07 à 11 05 04

Clearing the cache doesn't change anything.

Maybe since this one, line 251?

— WordPress : 6.1.1 wp-Typography : 5.9.1 PHP : 8.0.8

mundschenk-at commented 1 year ago

Sorry for not getting back to this earlier, do you still have this problem?

I just re-read the line you pointed out and indeed I accidentally removed the guard condition *oops*

theamnesic commented 7 months ago

Hi @mundschenk-at

Do you have any idea of the 5.9.2 release date?

Thanks!

mundschenk-at commented 7 months ago

Really soon now (sorry, I got sidetracked last year). I am currently updating the underlying PHP-Typography package, so that there will be some additional typographic improvements (well, bug fixes mostly).