search

muneebullashariff / i2c_vip

Verification IP for I2C protocol
Apache License 2.0
36 stars 73 forks source link

TB Arch #1

Open muneebullashariff opened 5 years ago

muneebullashariff commented 5 years ago

I checked on the TB arch doc and I have few points to make:

1) There is no DUT in this project 2) The write and read agents are inappropriate here. The master can be either in transmit mode(write) or in receive mode(read). Ideally, it should be the master agent and slave agent connected back-to-back

muneebullashariff commented 5 years ago

The new TB arch is amazing! I could see the ambitious work of adding virtual sequencer and virtual sequences, which is good initiative. Keep up the good work 👍

I have few points to make: 1) Name the master and slave agents as, master I2C agent and slave I2c agent as this TB arch is for I2C project. 2) The static interface is missing from the diagram. The static interface is instantiated in the top_module and then the virtual interface(pointer) is used inside the ENV.

Please incorporate these changes.

shvetatotad commented 5 years ago

Hi Muneeb,

Thank you for reviewing the testbench architecture, I appreciate the time and efforts you are putting to review the pulpino soc project. I'll try to update the TB architecture and include the features you suggested.

Thanks and Regards, Sweta Basavaraj.

On Thu, May 30, 2019 at 12:36 AM Muneeb Ulla Shariff < notifications@github.com> wrote:

The new TB arch is amazing! I could see the ambitious work of adding virtual sequencer and virtual sequences, which is good initiative. Keep up the good work 👍

I have few points to make:

  1. Name the master and slave agents as, master I2C agent and slave I2c agent as this TB arch is for I2C project.
  2. The static interface is missing from the diagram. The static interface is instantiated in the top_module and then the virtual interface(pointer) is used inside the ENV.

Please incorporate these changes.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/muneebullashariff/i2c_vip/issues/1?email_source=notifications&email_token=AGAORYSBJH275E2JEFJAUMDPX57XHA5CNFSM4HOHSG42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRTTKI#issuecomment-497236393, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAORYT75FIECPW2AVEOM4LPX57XHANCNFSM4HOHSG4Q .