search

mung3r / ecoCreature

PvM/E Rewards
http://forums.bukkit.org/threads/29538
GNU Lesser General Public License v3.0
7 stars 12 forks source link

mcMMO Weapon Skills #89

Closed javacraft closed 11 years ago

javacraft commented 11 years ago

Running on latest dev build #2447 with ecoCreatures 0.1.2 and latest McMMO build. Using default configurations for ecoCreature.

It seems that mcMMO's weapon skills are generating additional entity death events that are not recognized by ecoCreature and show up as

You slayed a using a

mung3r commented 11 years ago

So far, I'm not able to reproduce the error. Any other information on your setup to help me reproduce the error?

javacraft commented 11 years ago

Sorry for the delay. I will look into this and report with more details.

javacraft commented 11 years ago

Ran a minimal install with the following configurations:

I doubt it makes a difference, but equipped weapon was a Diamond Sword (no enchants). Set time to night and start killing mobs. Eventually you will get the You slayed a <crt> using a <itm> message. It happens infrequently but it does happen.

A better testing scenario is to enable Essentials - or similar plugin - set god mode. Also max out mcMMO weapon skills to increase chance of special attacks. Set nighttime and spawn two dozens Zombies. Have at them and you should see the message. If not, spawn another set of mobs.

I'm in the middle of upgrading our production server at Veterancraft. Once that's done, I'll see about download the ecoCreature source and track the errant message to its root cause.

javacraft commented 11 years ago

What's the story with the ci.herocraftonline.com repo? Thought I would have a chance to do some more serious debugging and I'm fighting with Maven build issues. Had to resort to adding systems directives for Vault and DeathTpPlus to get a clean install. Not sure if I'll have time now, but I'll see if I can discovery some more details tomorrow.

javacraft commented 11 years ago

With a fresh cup of coffee in hand and a buildable ecoCreature, I was able to nail down the issue fairly quickly. The errant message is a result of a McMMOPlayerLevelUpEvent, not entity death events due to mcMMO skills as I had originally suspected.

The You slayed a <crt> using a <itm> message appears to be the default NoReward_Message for a mcMMOLeveled configuration. Setting NoReward_Message to an empty string resolves the issue. It would be prudent to set the default NoReward_Message to an empty string unless otherwise specified in a configuration file.

mung3r commented 11 years ago

There's a similar bug with Heroes leveling. Thanks for debugging the issue.

Try out this build and see if it's fixed.

javacraft commented 11 years ago

Thx, I will try that build on our test server and see what happens.

javacraft commented 11 years ago

Everything works as expected using the latest release on Bukkit Dev. There no longer is a need to specifically set NoReward_Message for a mcMMOLeveled event. Always glad to help and thank you for resolving the issue.

Best,

Frelling