Assignment 2 Submission

[mungovan]

Hi guys,

This is my Google image search assignment.

@nesquena @timothy1ee

[nesquena]

:+1: decent work Declan. A few notes after checking out the code:

• Code formatting / whitespace could be cleaned up
• Consider better organizing your source files
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Your pagination is incorrect because "start" param is an offset rather than page i.e 0, 8, 16
• Consider moving the search field into the ActionBar using a custom ActionBar layout or SearchView
• Properly used spinners (with populated values) to allow users to select filters
• One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e SearchFilters.java) representing all the filters which was passed back and forth in the activities in the bundle
• Consider adding the ability to share an image. This is an important learning for this assignment even though it's optional.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[mungovan]

Hi Nathan,

Thanks for the detailed code review, I appreciate it! I'm going to block more time for this weeks project for sure and try and implement all your suggestions in it.

Rgds, Declan

Kind Regards, Declan

On 26 March 2014 03:48, Nathan Esquenazi notifications@github.com wrote:

[image: :+1:] nice work Declan. A few notes after checking out the code:

• Code formatting / whitespace could be cleaned up
• Consider better organizing your source fileshttp://guides.thecodepath.com/android/Organizing-your-Source-Files
• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Your pagination is incorrect because "start" param is an offset rather than page i.e 0, 8, 16
• Consider moving the search field into the ActionBar using a custom ActionBar layouthttp://guides.thecodepath.com/android/Extended-ActionBar-Guide#custom-actionbar-layoutor SearchViewhttp://guides.thecodepath.com/android/Extended-ActionBar-Guide#adding-searchview-to-actionbar
• Properly used spinners (with populated values) to allow users to select filters
• One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e SearchFilters.java) representing all the filters which was passed back and forth in the activities in the bundle
• Consider adding the ability to share an imagehttp://guides.thecodepath.com/android/Sharing-Content-with-Intents. This is an important learning for this assignment even though it's optional.

Also, here's a more detailed Project 2 Feedback Guide herehttps://gist.github.com/nesquena/44091e4727b154d04269which covers the most common issues with this submitted project. Read through the feedback guide point-by-pointhttps://gist.github.com/nesquena/44091e4727b154d04269to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

Reply to this email directly or view it on GitHubhttps://github.com/mungovan/GoogleImageSearch/issues/1#issuecomment-38669846 .