Twitter CLient Submit

[mungovan]

Hey,

I got the required stuff complete and some of the pull to refresh stuff as well, but unfortunately ran out of time to fully implement that component.

On my eclipse I had added the PullToRefreshListView project (as library), but not sure how to include it in the commit. I'm worried it may cause errors on your side when you try to compile.

@nesquena @timothy1ee

[nesquena]

:+1: nice work overall Declan. A few notes after checking out the code:

• Good to see you were able to format the timestamp cleanly
• Good to see you added the tweet to the home timeline after you posted new on compose
• Consider adding the character count for Compose Activity to limit to 140. See this event handler for more details.
• Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

On my eclipse I had added the PullToRefreshListView project (as library), but not sure how to include it in the commit. I'm worried it may cause errors on your side when you try to compile.

I fix the projects by loading my own copy once I import, so it works OK.

[mungovan]

Hi, I started some re-factoring last night and screwed something up with the user timeline that is produced when clicking on someone else's profile. For some reason it's bringing up my timeline, even though the user id that is being passed in is correct. I was debugging through it today but couldn't figure out what the cause was :(

@nesquena

[nesquena]

I was debugging through it today but couldn't figure out what the cause was :(

Declan, can you please track this down and correct it ASAP? The issue is that the user timeline is not getting the screen_name or user_id passed? see here. The user timeline is never told which user to actually render a timeline for....Please correct this and ping back.

[nesquena]

The core is how does this user timeline know which users timeline to render? It doesn't look like the user id is being used?

[mungovan]

Hi Nathan, I checked in a quick fix for the Timeline issue. So when I was re-factoring it yesterday I removed the separate method call for retrieving tweets and wanted a generic "getTweets" call, whose content would be defined by the fragment requesting the tweets.

I guess I forgot to add in the user Id with the requested string.

Thanks for the help, appreciate it!

[nesquena]

:+1: nice work overall. A few notes after checking out the code:

• In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
• Consider adding progress bars to your app whenever a network request goes out
• For tabs, try following this approach for cleaner tab listeners and better memory management.
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
• Consider adding local persistence of tweets by using ActiveAndroid in the Tweet and User. See the persistence guide and this other guide for more details.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

I guess I forgot to add in the user Id with the requested string.

Glad it was a fairly easy fix!

[mungovan]

Thanks for reviewing again!

Kind Regards, Declan

On 9 April 2014 00:28, Nathan Esquenazi notifications@github.com wrote:

[image: :+1:] nice work overall. A few notes after checking out the code:

• In the future, definitely consider additional polish for the UIhttps://gist.github.com/nesquena/6c567083aec13d868017by reviewing the cloning a screenhttps://github.com/thecodepath/android_guides/wiki/Cloning-a-Login-Screen-Layouttutorial and Q&A and the drawableshttps://github.com/thecodepath/android_guides/wiki/Drawablesguide.
• Consider adding progress barshttp://guides.thecodepath.com/android/Handling-ProgressBars#actionbar-progress-barto your app whenever a network request goes out
• For tabs, try following this approachhttps://github.com/thecodepath/android_guides/wiki/ActionBar-Tabs-with-Fragments#without-gingerbread-supportfor cleaner tab listeners and better memory management.
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!
• Consider adding local persistence of tweets by using ActiveAndroid in the Tweet and User. See the persistence guidehttps://github.com/thecodepath/android_guides/wiki/Persisting-Data-to-the-Device#object-relational-mappersand this other guidehttps://github.com/thecodepath/android_guides/wiki/ActiveAndroid-Guidefor more details.

Here's a detailed Project 4 Feedback Guide herehttps://gist.github.com/nesquena/d88cf3606a308359323fwhich covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

I guess I forgot to add in the user Id with the requested string.

Glad it was a fairly easy fix!

Reply to this email directly or view it on GitHubhttps://github.com/mungovan/TwitterClient_1/issues/1#issuecomment-39935855 .