search

munhouiani / Deep-Packet

Pytorch implementation of deep packet: a novel approach for encrypted traffic classification using deep learning
MIT License
183 stars 56 forks source link

UDP padding #19

Closed cherepanovic closed 2 years ago

cherepanovic commented 2 years ago

Hello,

I assume you pad UDP with the function pad_udp(packet) because the difference between UDP and TCP is exactly 12 bytes.

However, TCP might have also an optional field up to 20 bytes. There is no checkup for this optional length, as I can see. Do I overlook something?

best regards

munhouiani commented 2 years ago

You are right, we didn't check the TCP length here.