feat: improve gdata explorer

muni-town / weird

Weird web pages

https://weird.one

Other

51 stars 11 forks source link

feat: improve gdata explorer #117

Closed azzamsa closed 4 months ago

azzamsa commented 4 months ago

feat: cylce doc list
feat: cycle through the list when reaching the end

https://github.com/user-attachments/assets/8968fc2e-3964-45d9-b3c2-6ea1d4bd6d4b

feat: help popup

https://github.com/user-attachments/assets/6d5fb1fd-b312-4528-9c0c-a388322c6d36

feat: update document value on key press

https://github.com/user-attachments/assets/7b2a9725-1995-4489-a300-6be206f03503

azzamsa commented 4 months ago

@zicklag some notes

I duplicate the code under KeyCode::Down and KeyCode::Up, both in Home View and Namespace View. Otherwise, I would get many borrow error warnings.
I don't handle Value is not null or a map, not initing map. The app will just exit if it finds a key without a Value.

Curious about the latter, why does the store contain a key without a value? Should I treat any error that comes from get_or_init_map as an empty value?

zicklag commented 4 months ago

Awesome!

As far as your second note, it happens when you try to get a value that is not a map. The get_or_init_map tries to get a map, or create it if it doesn't exist. If it isn't a map, then it complains, because it's already some other kind of value.

I wouldn't worry about that right now, though, because we're getting close to moving to our new Leaf data model.

Everything you've updated here will still help and won't need to change much, but we probably want to wait on further updates until I get #122 merged.