search

munificent / craftinginterpreters

Repository for the book "Crafting Interpreters"
http://www.craftinginterpreters.com/
Other
8.42k stars 1.01k forks source link

Add lox to GitHub Linguist? #1144

Open HallofFamer opened 8 months ago

HallofFamer commented 8 months ago

It seems that it is possible for us to add Lox as a language at Linguist. We will need to submit a PR to linguist (https://github.com/github-linguist/linguist) and complete the checklist:

  1. The extension of the new language is used in hundreds of repositories on GitHub.com.
  2. I have included a real-world usage sample for all extensions added in this PR.
  3. I have included a syntax highlighting grammar.
  4. I have added a color.
  5. I have updated the heuristics to distinguish my language from others using the same extension

I think we do have hundreds of repos that include Lox script files, also a syntax highlighting grammar plugin is available on vscode (https://marketplace.visualstudio.com/items?itemName=dberezin.lox-language). I am not sure if there’s a good example of real world application written in Lox, but maybe someone can share the findings (perhaps the Loxlox interpreters count?)

Note: I have found at least 1 Lox derived language on GitHub linguist already, so I don’t see a reason why Lox shouldn’t be on the list too.

@munificent What is your thought about this? We will not make such a request without your approval.

munificent commented 8 months ago

I would love it!

HallofFamer commented 8 months ago

Thx @munificent, I have forked linguist and created a branch ‘add-lox’, will work on it in a few days and hopefully will have a pull request ready after I complete the proposal.