munificent / hauberk

A web-based roguelike written in Dart.
http://munificent.github.io/hauberk/
Other
2k stars 200 forks source link

Casting the spell "Icicle" on yourself. #38

Closed groothecommenter closed 6 years ago

groothecommenter commented 6 years ago

Casting the spell "Icicle" on yourself will cause the spell animation to endlessly repeat, preventing you from issuing any commands.

I am playing the game through my default browser (Firefox), and I've not yet tested anything on but my local machine.

Probably best to not ask why I was casting offensive spells against myself.

I'm really enjoying your game so far, with a long history of classical roguelikes under my belt I can readily feel the thought and care in the code. I hope things go well for you and you continue to have time to work on it. If this comment helps to bring any fixes or additions to your work, I'm glad it helped and was worth your time.

munificent commented 6 years ago

Hahaha, oops, yes! The LOS code that walks the line is getting stuck in an infinite loop since the direction vector is zero. It should check for that case and prevent it from happening. :)

I hope things go well for you and you continue to have time to work on it. If this comment helps to bring any fixes or additions to your work, I'm glad it helped and was worth your time.

Thank you! I definitely plan to sink copious amounts of time into it.