search

munificent / magpie

The Magpie programming language
http://magpie-lang.org
Other
360 stars 34 forks source link

Linux support #23

Closed Sh4rK closed 12 years ago

Sh4rK commented 12 years ago

New pull request + commit. I messed up the previous repo. (I need to learn Git properly :)

Everything should be fixed here.

munificent commented 12 years ago

Looks great! Merged it into master.

I think you did the right thing git-wise here. Things are a little simpler if you do your changes in a feature branch like you did here. That way you can merge fetch from the master branch and them merge them into your feature branch.

(I should probably also do my work on branches instead of master but... uh... I'm lazy and up until now I was the only one really hacking on this. :) )

At some point, I'm going to poke at gyp and try to get some platform-specific source files set up so there aren't as many #if throughout the code. When I do that, I'll definitely appreciate any testing help to make sure I don't break Linux and Windows. Thanks again!

Sh4rK commented 12 years ago

Yes, I decided ceating a new branch would make things a bit easier to manage :)