munin-monitoring / contrib

Contributed stuff for munin (plugins, tools, etc...)
http://munin-monitoring.org
1.05k stars 683 forks source link

Add plugins - ipmi_fan_sd and ipmi_voltage_sd #55

Closed sverigedemokraterna-it closed 12 years ago

sverigedemokraterna-it commented 12 years ago

Monitors fan rpms on an IPMI-server.

https://it.sverigedemokraterna.se/program/ipmi_fan_sd/ https://it.sverigedemokraterna.se/files/2012/02/ipmi_fan_sd-1.0.zip

Monitors voltages and watts on an IPMI-server.

https://it.sverigedemokraterna.se/program/ipmi_voltage_sd/ https://it.sverigedemokraterna.se/files/2012/02/ipmi_voltage_sd-1.0.zip

kenyon commented 12 years ago

How are these different from the existing ipmi plugins? There are two in the main munin distribution, node.d.linux/ipmi_ and node.d/ipmisensor, and a bunch in contrib, some of which are probably old versions of the ones in the main distribution: ./plugins/ipmi/ipmi_ ./plugins/system/ipmisdr ./plugins/sensors/freeipmi_ ./plugins/sensors/ipmisens-v3 ./plugins/sensors/ipmi_fans ./plugins/sensors/ipmitoolsensor ./plugins/sensors/ipmi_therm ./plugins/other/ipmisensors ./plugins/other/ipmisensor

sverigedemokraterna-it commented 12 years ago

Unless my munin skills are terrible, none of them are about to tell me whether a fan or psu has stopped working. See the "fails" fields in both my plugins.

I've tried adding a "fan1.min" env in order for munin to tell me that fan1 is lower than 1000 rpm but that didn't work. Warnings and criticals only tell me that a fan is spinning faster than x.

It's up to you whether you want to add the plugins or not. I've written them, if anyone else has a use for them then good for them.

ps: I'm of the opinion that ipmi plugins should all be placed in the ipmi directory. All those sensor plugins are useless without a ipmi support on the motherboard.

kenyon commented 12 years ago

I wonder why not improve the existing plugins instead of write a complete new one.

There are other ways besides IPMI to get sensor data, such as with lm_sensors.

sverigedemokraterna-it commented 12 years ago

Didn't really realize that I was allowed to work on other people's plugins like that.

kenyon commented 12 years ago

Indeed! You are very welcome to improve on the work of other people here. Please do read the github help, fork this repository, make changes, and submit pull requests!