search

munki / munki-pkg

Repo for the munkipkg tool and example projects
Other
345 stars 73 forks source link

Add version number to package name that gets written to disk. #3

Closed natewalck closed 8 years ago

natewalck commented 9 years ago

Added version number to package name when written to disk so humans don't get confused. Also made it so that .pkg is not required in the name key for the output file to get a file extension.

gregneagle commented 9 years ago

Not sure I want to do this. For this tool I think I want things to be as explicit and obvious as possible -- I don't want a lot of "magic happens here". If you want the version number in the pkg name, when you update the version, update the name.

erikng commented 8 years ago

:(

natewalck commented 8 years ago

Can this be made an option? This would be super useful for mere mortals who have to work with these packages manually (and provide a natural way of naming them coming from luggage).

gregneagle commented 8 years ago

You have to manually update the version when you revise the pkg. Update the name to match your naming convention at the same time. Other sites might want to put the date in there, or who built it, or some other metadata.

erikng commented 8 years ago

I will admit I have overwritten my own working directory many times when building packages as I would forget to change the name.

This is the one biggest things I miss from luggage. If an admin wanted a date in there, it would be great if the plist/JSON would support that via a specific string and automatically append the date.

That said, it's not a huge pain point.

Sent from my iPhone

On Dec 9, 2015, at 3:24 PM, Greg Neagle notifications@github.com wrote:

You have to manually update the version when you revise the pkg. Update the name to match your naming convention at the same time. Other sites might want to put the date in there, or who built it, or some other metadata.

— Reply to this email directly or view it on GitHub.

natewalck commented 8 years ago

Another go at this: https://github.com/munki/munki-pkg/pull/12