search

munki / munki-pkg

Repo for the munkipkg tool and example projects
Other
343 stars 75 forks source link

err not defined in scope #40

Closed MichalMMac closed 4 years ago

MichalMMac commented 5 years ago

Discovered by flake8 formatter: undefined name 'err'

https://github.com/munki/munki-pkg/blob/30f4373bd09ccf3cc7517c7ddea1c48121ecfa7a/munkipkg#L178

IMHO err is only defined withing previous except block.

gregneagle commented 4 years ago

Interesting that pylint missed this!

gregneagle commented 4 years ago

I don't remember when this got addressed, but the issue isn't present in the current code as far as I can see. Closing.

MichalMMac commented 4 years ago

git blame shows It got fixed in the commit https://github.com/munki/munki-pkg/commit/c3b3c04fb458e41664cb925028c6206c97c1055e

Great! :-)