search

munki / munki-pkg

Repo for the munkipkg tool and example projects
Other
343 stars 75 forks source link

Replace basestring with string_types #41

Closed MichalMMac closed 4 years ago

MichalMMac commented 5 years ago

Use string_types from six library to ensure Python2/Python3 compatibility.

gregneagle commented 5 years ago

For a variety of reasons, I'd rather not rely on six right now (a big part of that is that the six provided by Apple is quite old and I don't have the time/energy to test code against that six and more modern sixes that might be in other Python frameworks.)

Where I am updating Munki for Python 3 compatibility, I'm using this: https://github.com/munki/munki/blob/Munki3dev/code/client/munkilib/wrappers.py#L124-L131 to replace most of the needs of that.

MichalMMac commented 5 years ago

Ok. Please see the fixup 25dd9596b818ff69b8a865d7010af196905d7c27

I need to squash the fixup and reword the commit message before merging.

MichalMMac commented 4 years ago

This problem was fixed in the commit https://github.com/munki/munki-pkg/commit/c3b3c04fb458e41664cb925028c6206c97c1055e not related to this PR. Closing.