munki / munki-pkg

Repo for the munkipkg tool and example projects
Other
343 stars 75 forks source link

Change shebang to reference munki-python #59

Closed rodchristiansen closed 2 years ago

rodchristiansen commented 2 years ago

Support for upcoming macOS 12.3 -- initial testing on my end seems it just works with new shebang. Can others confirm? Thanks.

gregneagle commented 2 years ago

This change makes munki-pkg require Munki, which it currently does not.

My inclination is to do one of the following:

1) Change the shebang to #!/usr/bin/env python and tell people to configure a valid Python in their environment, or 2) Remove the shebang altogether and tell people to just run it as an argument to some Python install.

An example for option 1: sudo ln -s /usr/local/munki/munki-python /usr/local/bin/python (assumes /usr/local/bin is in your PATH before /usr/bin and assumes there is currently nothing at /usr/local/bin/python)

An example for option 2: /usr/local/munki/munki-python ./munkipkg --create Foo

gregneagle commented 2 years ago

I decided to go with option 1. If that causes too much support pain, I'll remove the shebang altogether.