search

munki / munki-pkg

Repo for the munkipkg tool and example projects
Other
343 stars 75 forks source link

python3 pkg --import issue resolution, readme tweak #64

Closed arubdesu closed 1 year ago

arubdesu commented 1 year ago

You can cherry-pick-drop the readme if it's too clumsy, but luckily @arequ found the fix to the issue I described in #62

gregneagle commented 1 year ago

This appears to be the right fix for Python 3; I wonder if this breaks things under Python 2. Perhaps we don't care any longer.

arubdesu commented 1 year ago

Should I bump the version and add a note to the readme if this is a good enough thing to do now?

arubdesu commented 1 year ago

Feel free to cherry-pick out the commit with the README change if that's still up for debate, I just want to make sure the python3 fix makes it into main, or we can certainly discuss that further as well.

arubdesu commented 1 year ago

Is there something else I can do/should be addressing to help move this along?

YesThatAllen commented 1 year ago

This appears to be the right fix for Python 3; I wonder if this breaks things under Python 2. Perhaps we don't care any longer.

If the former is true, I think the latter is true as well... a tag could be made for python2 users to check out, and the latest code doesn't consider python2 anymore.

To that end, perhaps the readme conversation could be settled by updating the shebang to 

- #!/usr/bin/env python
+ #!/usr/bin/env python3

.. which I assume would have the extra benefit of preventing python2 users from having a bad day.

gregneagle commented 1 year ago

I've simply changed the shebang to #!/usr/bin/env python3. How you get python3 in your PATH is up to you.