munki / mwa2

Version 2 of MunkiWebAdmin
Other
157 stars 37 forks source link

Lock plist editor fields to vertical resizing #38

Closed chrisgrande closed 5 years ago

chrisgrande commented 5 years ago

Fixes issue #16 by disabling horizontal field resizing. Fields can still be vertically resized if needed.

gregneagle commented 5 years ago

On Safari I can still do this when resizing:

image
gregneagle commented 5 years ago

Notice how the first column has been squeezed out of existence.

chrisgrande commented 5 years ago

Oops - I didn't apply the fix to the manifest editor just the pkginfo editor. New commit applies to both.

gregneagle commented 5 years ago

Still wonky:

image
chrisgrande commented 5 years ago

Hmm, I can't reproduce it - are you just dragging the resize handle in the corner of the field? With those two commits it should only allow the fields in both editors to be resized vertically.

gregneagle commented 5 years ago

"are you just dragging the resize handle in the corner of the field?" yep. "With those two commits it should only allow the fields in both editors to be resized vertically." I'm still seeing some horizontal resizing.

Also: if you disable horizontal resizing -- what happens when the browser window is resized? It looks to me like the fields do not adapt their width...

chrisgrande commented 5 years ago

Very strange, I'm not seeing either issue. They resize on browser resize and don't budge if I try to resize them.

gregneagle commented 5 years ago

Thanks for this fix!