search

munkireport / munkireport-php

A reporting tool for munki
MIT License
392 stars 138 forks source link

WIP: Freezing when submitting a Business Unit / Machine Group #1503

Open mosen opened 1 year ago

mosen commented 1 year ago

in v6, precursorca found an issue saving BU's / machine groups:

MR6 Business Units / Machine Group creation forms have a glitch.
It shows a Submit button AND a Save button. Clicking either results in the page freezing.
But if you immediately Sign Out and then log back in to MR6 you find the Business Unit / Machine Group has indeed been created.
mosen commented 1 year ago

Does not freeze for me so need to repro. The new BU does get appended without any padding though, so it looks horrible. Also adding a machine group straight after does not pick up the name you entered.

mosen commented 1 year ago

Fixed an issue adding new machine groups to a BU. Still does not generate a groupid/key when creating a BU

mosen commented 1 year ago

A key difference is in the frontend: v5 will submit form values for "key", "keys", and "groupid" if creating a new business unit, but this doesnt seem to make sense