Open goblain opened 8 years ago
Agreed. The 301 redirect in serve was a temporary measure and is less than ideal.
I think the best solution moving forward is as you say, automatically configuring the Ingress resource to add and remove the /.well-known/acme-challenge/ as this pushes the onus for redirecting onto the ingress controller or ingress definition.
As I understand, the serve mode is now used to serve acme-challenge and redirect other requests to from HTTP to HTTPS.
I think that this expands the responsibility above the required minimum. For starters, to keep backwards compatibility I'd suggest simply switching the default example to something like :
where https-redirect service is obviously responsible for the actual redirects if they are required. In the long run I would suggest the path for
/.well-known/acme-challenge/
be created in a completely automatic way without need to specify it in the ingress, and if http ingress does not exist it can create a whole temporary ingress.