Reworking of kube-plex - Githubissues

ressu commented 3 years ago

NOTE: This was originally filed at https://github.com/munnerz/kube-plex/pull/113 which got closed due to renamed branch on my fork.

I'll admit, this is a "scratch my own itch" type of a solution. But when trying to make use of kube-plex, I ended up having a few issues. So I reworked quite a bit of it.

I'm dropping this PR as a heads up that this work has been done, I'm more than happy to try and break it down to smaller chunks for merging. Some changes included (in no specific order):

switch to using Job instead of Pod
use Kubernetes garbage collection to make sure that no pods are left behind
Transcoder properly shuts down when Plex force kills it (which seems to be the default behaviour)
Log messages to Plex logs to make debugging easier
No longer depends on /config on the transcoder, which enables more efficient PVCs for config
Properly supports subpaths
Adds a reverse proxy to the transcoder since Plex assumes localhost in way too many places
Adds tests to the codebase..

I'm also dropping vendor directory from the repository. Personally I prefer to have it, but it tends to mess up pull requests. I've also constructed all the Dockerfiles etc in a way where it's completely fine to either run everything as is, or by pre-caching the modules with go mod vendor.

m4dm4rtig4n commented 3 years ago

It would seem that the initial project is unmaintained... Are you taking over the project ?

ressu commented 3 years ago

I'm considering that as an option. I've already enabled many of the project features on the repository I have and welcome bug reports and pull requests there.

karezza commented 2 years ago

ressu, I think it may be time for you to just fork a new instance and everyone can move to that, get it into a kind of chart repo that we can all use to upgrade, the last version of plex, hard coded in, in the kube-plex chart is over 2 years ago. I'll help where I can but I'm new to kubernetes. Seems like you know what to do though, and even if you don't take over with the main development, you could approve the merge requests of others.

munnerz / kube-plex

Reworking of kube-plex #114