Feature Request : More customization on Charts from values.yaml

[SebastienTolron]

Hi Munnerz !

First of all , really great job on this helm chart. Works like a charm !

I had to make some customizations , and I think It can be pretty good to include them in the base chart.

Here is what would be good I think :

• Provide some parameters for volumes : Some people will need to use a NFS for making this to work. You should probably allow more customizations on volumes. For exemple , I had to change the volumes sections for shared

    - name: shared
      flexVolume:
        driver: rook.io/rook
        fsType: ceph
        options:
          fsName: nfs-plex 
          clusterName: rook 

  That would be good to provide the entire config in values.yml if needed to customize it.

• SecurityContext : This is related. You should provide option to allow customize securityContext , so right will be managed properly on NFS

• Ingress : A basic ingress rule would be pretty cool for this chart :)

• PLEX_GID : This would be very good to have a parameter for that.

Well this is a lot , and I customized that for my need , but I'm pretty sure people would love this in order to allow more customizations from values.yaml.

I know this can be a lot of work , but let me know what do you think about this , and I can help if needed.

Keep rocking :grinning:

[SebastienTolron]

Also , allowing to use theses nfs with pms-elastic-transcoder. It looking for a PVC class , but when creating file systems it won't work

[gandazgul]

Check out my PR for this: https://github.com/munnerz/kube-plex/pull/51

securityContext and ingress have been added as well since you wrote this.

[denebeim]

I've been digging into the code today. This is not really doable in the current design. The main code here that creates the pod is a static structure. Basically every different storage type, etc would cause a bunch of special case logic. The code here is going to take some major restructuring to make it work. Either it's going to have to introspect the pod and create a new one like it, or be fed a pod configuration in a string and call a parser somewhere. Either of these is beyond me at my current understanding of k8s, but I may go back and visit it when my expertise is better. Is anyone interested in helping me with this? If so mosey on over to my fork and talk at me.

[gandazgul]

I think asking the API for the pod details and creating the other ones with the same settings is the way to go. This way the chart can be customized in almost any way without changing anything else.

[denebeim]

Yes, that's exactly what I was thinking. Either that or just take whatever configuration the plex server is running.