use old style function() syntax, to fix bug with minification for prod build

munshkr / ejs-brunch

Adds EJS template compilation support to Brunch

4 stars 4 forks source link

use old style function() syntax, to fix bug with minification for prod build #5

Closed radzserg closed 6 years ago

radzserg commented 7 years ago

I found another issue when building with -p flag. Looks like the problem in order of operations. So when I ran brunch build -p I got an issue with minification

24 Nov 18:28:17 - error: JS minification failed on www/dist/js/app.js: SyntaxError: Unexpected token: operator (>) (line: 14480, col: 21, pos: 646029)

I checked it out app.js and found out that is contain non-converted ES2015 javascript. I made a hotfix with updating to old syntax and it works fine now.

munshkr commented 6 years ago

Thank you, I'm sorry I forgot about this PR and never merged it. I've just merged another one that includes the same fix, and another arrow function, so I'll close this one.