Bug: Pedestrian doesn´t work in isoline

enriquevaa commented 1 month ago

Bug isoline When you use the function isoline(), it doesn´t support the argument transport_mode = 'pedestrian' anymore. It works well with car or truck.

Reproducible example isoline( poi = point, range = 60*3, range_type = "time", transport_mode = 'pedestrian')

The API request is the following:

In .parse_response(i, out$responses()[[i]]) :
  https://isoline.router.hereapi.com/v8/isolines: Request 'id = 1' failed. 
  Status 400; Bad Request; Bad request syntax or unsupported method.

I hope you can solve this problem, looks it has happened since the Here API update.

munterfi commented 1 month ago

Thanks @enriquevaa for reporting.

It seems that hereR::isoline() is sending EV parameters, which are not valid with the routing mode "pedestrian":

Invalid request: https://isoline.router.hereapi.com/v8/isolines?origin=47.133724,9.516669&departureTime=2024-10-11T21:23:43%2B02:00&transportMode=pedestrian&range[values]=300,600,900,1200,1500,1800&range[type]=time&optimizeFor=balanced&ev[freeFlowSpeedTable]=0,0.239,27,0.239,45,0.259,60,0.196,75,0.207,90,0.238,100,0.26,110,0.296,120,0.337,130,0.351,250,0.351&ev[trafficSpeedTable]=0,0.349,27,0.319,45,0.329,60,0.266,75,0.287,90,0.318,100,0.33,110,0.335,120,0.35,130,0.36,250,0.36&ev[ascent]=9&ev[descent]=4.3&ev[auxiliaryConsumption]=1.8&departure=2024-10-11T21:23:43%2B02:00

{
  "title": "Invalid request",
  "status": 400,
  "code": "E605027",
  "cause": "Ev parameters cannot be used with the specified `transportMode`.",
  "action": "",
  "correlationId": "ec167d27-9ca9-484f-a969-5ba5bb5aa6fb"
}

Valid request: https://isoline.router.hereapi.com/v8/isolines?origin=47.133724,9.516669&departureTime=2024-10-11T21:23:43%2B02:00&transportMode=pedestrian&range[values]=300,600,900,1200,1500,1800&range[type]=time&departure=2024-10-11T21:23:43%2B02:00

{
  "departure": {
    "time": "2024-10-11T21:23:43+02:00",
    "place": {
      "type": "place",
      "location": {
        "lat": 47.1337323,
        "lng": 9.5167141
      },
      "originalLocation": {
        "lat": 47.1337239,
        "lng": 9.5166689
      }
    }
  },
  "isolines": [
    {
      "range": {
        "type": "time",
        "value": 300
      },
      "polygons": [
        {
          "outer": "BGw4485Ciu4kSA29BsFkQkQqFiQpF4K3KiQrFkQsF2K4KkQqF-qBAiQsFsFkQrFiQhQsFvVAhQsF3K4KhQqFjQpF3KlgB1KA3K2KlgB4KrFiQAqrDrFiQ1KArFhQArgCrFhQ3K3KpFjQAl2EqFhQkQrFiQ2CsFgIAuN"
        }
      ]
    },
    {
      "range": {
        "type": "time",
        "value": 600
      },
      "polygons": [
        {
          "outer": "BGij485Cw3xkSA4SsFkQmgB2KA4K3K4KrFiQA61CsFkQkQsFsgCAiQrF4K3KiQrFkQsF2K4KkQsFuVAkQrF2K3KkQrFiQsF-qB-qBsFiQrFkQ3K4KrFiQsFkQmgBmgBA2KhQsFvVAhQrF3K1K1KArFiQA-qBrFiQ3KA1K1KjQrFhQsFrFiQsFkQiQqFuVAkQsFsFkQrFiQjQsFtVAhQsFrFiQA-qBrFiQtVwVjQsFtVAjQrFlgBlgBlgB3K1K3K3KArFkQA-qBsFiQ4K4KsFiQAwVrFiQjQsF7qBAjQrFA3K4K1KsFjQArgCrFhQ3KAlgBmgBhQsFjQrFA3K4K3K2KlgB-qB7qBmgB3KsFhQA9qBrFhQtVvV3KA3K4KhQsFtVAjQsF1K2KlgB4K3K4KlgB2K3K4KhQsFvVAhQrFrFjQsFhQiQrFwVAiQrF4K1KiQrFwVAiQrF4K3KmgB1K2K3KmgB3KwVtVsFjQA7qBrFjQjQrFtVAjQpFA3KkQrFuVAkQrFsFhQA51CrFjQlgB3KA1KmgBlgBsFjQAtVqFjQ4K1CsFiIAuN"
        }
      ]
    },
    {
      "range": {
        "type": "time",
        "value": 900
      },
      "polygons": [
        {
          "outer": "BGgu585C2hvkSrFsNlgB4KrFiQAsgCsFkQiQsF-qBAiQrF4K3KkQrF8qBAkQrF2K1KkQrF8qBAkQsFsFiQA4gEsFkQsgCsgCmgB2KqFkQAuVsFkQmgB2K4K4KmgB4KuVuVsFiQrFwVrFiQsF4KsFiQA-qBrFiQlgB4K1K4K3KA3KlgB1K3KrFhQA9qBrFhQlgB3KlgBlgBlgB3K3K1K1KArFiQAqrDsFiQmgB4KA2K3K4KrFkQsFiQ4KA2K3KkQpFuVAkQqFA4K9qB-qBlgB2KrFkQAuVsFkQ4K2KqFkQpFiQjQsFtVAjQrF1K1KjQrFrgCAhQsF3KmgBlgB2K3K4K1KA3K3K3KApFkQqFiQmgB4KA4KlgB2K1K4KjQsF7qBAjQrF3K3KlgB1KpFjQA7qBrFjQjQrFhQsFtVuVrFkQAuVrFkQjQsFhQrFrFjQAtVrFjQ1K1KA3KmgB3K2K1KmgB3KsFhQAvVsFhQ4K3K2KlgB4K3K2KlgB-qB7qBmgB3KsFhQA9qBrFhQtVvV3KA3K4KhQsFtVAjQsF1K2KlgB4K3K4KlgB2K3K4KhQsFvVAhQsF3K2KlgB4K1K2KjQsFtVAjQsF1K4KjQsFhQrFrFjQsFhQiQrFuVAkQrF4K1KmgB3K2K3KmgB1K4K3KiQrFwVAiQrF4K1KiQrFwVAiQrF4K3KmgB1K2K3KmgB3KwVtVsFjQA7qBrFjQjQrFtVAjQsF1K4KjQsFtVAhQsF3KmgB3K2K1KmgB9qB-qBjQsFhQrFrFjQsFhQ01Bz1BsFjQAtVsFjQuVtVkQrForDAkQrFsFhQA51CrFjQjQrFhQsF3K4KlgB2K1K4KjQsF9qBAhQsF3K2KhQsFvVAhQrFA1KuVvVkQpFuVAkQrFuVvVsFhQAprDsFhQ2KA4K2K4KA2K1KkQrFuVAiQrF4K3KmgB1K4K3KiQrFkQ2CsFiIAuN"
        }
      ]
    },
    {
      "range": {
        "type": "time",
        "value": 1200
      },
      "polygons": [
        {
          "outer": "BG8sz85CirokSAmzCsFiQ2K4KsFiQAqrDsFiQ4KA2K1KkQrFuVAiQrF4K3KmgB1K4K3KiQrFkQsFsFkQrFiQlgB4KrFiQAsgCsFkQ2KA4K3KkQrFuVAiQrF4K1KmgB3K4K3KiQpFwVAiQrF4K3KmgB3K2K1KkQrFuVAkQrF2K3KmgB1K4K3KiQrFkQsFA4KtVuVlgB4K3K2KlgB4KA4KiQsF-qBAkQrF2K3KmgB3KsFhQA9qBsFhQ4KA2KmgB4K2KsFkQAuVrFkQlgB2K3K4KhQsF9qBAhQsF3K2KjQsFtVAhQsFrFkQAorDsFkQsgCsgCiQqF-qBAiQsF4K4KiQsFkQrFsFjQArgCrFhQ3K3KrFhQsFjQkQpFiQqFsFkQA4gEsFiQiQsF-qBAkQsF2KmgB4K4KA2KtVwVjQqF9qBAhQsFrFkQsFiQiQsFwVsFiQsFsF3KsFhQiQrFkQsFsFiQrFkQ3K2KrFkQA8qBsFkQ4K2KsFkQrFiQlgBmgBrFkQAuVrFkQhQsFvVAhQqF3K4K1KA3KlgBjQrFhQsFrFkQAuVrFiQhQsFprDAhQsF3KmgBtVuVlgB4K3K4KhQsFjQrF3K3KhQrFtVsFjQkQ3KiQhQsF3gEAjQrF1K3KjQpFtVAhQqF3KmgBjQsFhQrF3K1K1KA11B01BhQsFjQrF1KlgB3K3KA1K4K3K2KlgB4K3KA1KlgB3KrFhQAvVsFhQiQrF-qBAkQrFqFhQA3gEpFjQvVtVhQrFjQsF1K2KjQsFtVAjQsFrFkQAy2GpFiQjQsFhQrF3KhQjQjQhQ1KrFjQsFhQiQrFwVAiQrFA3K1K1K3KlgBjQrFtVAhQrF3KlgBhQrFjQsF3K4KhQsFtVAjQrFrFjQsFhQuVvVkQpFuVAkQrF2K3KmgB3KwVtVqFhQAprDsFhQ4KAsFiQA-qBsFiQ2KAwVtV2KlgBwVtViQrF-qBAiQrFsFjQAl2EsFhQuVvVkQpFuVAkQrFuVvVsFhQA9qBrFhQlgB3KrFhQAvVsFhQ4K3KqFhQAz2GsFhQ4K1CsFiIAsN"
        }
      ]
    },
    {
      "range": {
        "type": "time",
        "value": 1500
      },
      "polygons": [
        {
          "outer": "BGs8w85C25gkS4KiI4KmgB2K2KsFkQAuVsFkQ4K2K2KmgB4KA4K1KmgB3K2K3K4KAsFkQrFiQlgB4KrFiQA-qBsFkQ4K2KqFkQAuVpFkQ3KA3KlgB1KArFiQA-qBsFiQ2K4KsFiQAqrDsFiQ4KA2K1KkQrFuVAiQrF4K3KmgB1K4K3KiQrFkQsFsFkQrFiQlgB4KrFiQA-qBsFiQiQsFwVAiQrF4K1KmgB3K2K3KmgB1K4K3KkQrFuVAiQrF4K1KmgB3K4K3KmgB1K2K3KkQrFuVAkQrF2K1KmgB3K4K3KiQpFwVAiQqFsFkQrFiQlgB4KA4KwVuViQsF-qBAiQrF4K3KiQpFsgCAkQqFA4KjQsFtVAjQsF1K2KjQsF7qBAjQsF1K4KlgB2KrFkQA-qBsFiQ2K4KsFiQAsgCsFkQ4KA2K3KmgB3K4K1KmgB3K2K3KkQpFiQqFsFkQrFiQlgB4K1K4KlgB2K3K4KlgB4KtVuVrFiQAwVsFiQiQsFsgCAkQrF8qB7qB4KlgBkQrFuVAiQsFsFiQrFkQpF2KqFkQsFuVrFkQ1K2K3KmgBlgB4KrFiQAwVsFiQmgB4K4KmgB01B01BA4KlgBmgBA2K4K4KA4KlgB2KA4K2K4KA2KlgBmgBA4KmgB4KA2KlgB4K1K4KlgB2KA4K2K4KsFiQrFkQ1KA3K3KlgB3K1K1KlgB3K3K3KjQpFtVAhQrF3K3KjQrFl2EAhQsF3KmgBtVuVlgB4K3K4KhQsFjQrF3K3KhQrFtVsFjQkQ3KiQhQsF3gEAjQrF1K3KjQpFtVAhQqF3KmgBjQsFhQrF3K1K1KAxgDygDlgB2K3K4KlgB4KlgBmgBjQqFtVAhQpFA3K2K3K4KlgB4K1KqFjQA9qBpFhQjQrFhQsF3K4KhQqFjQpFrFjQsFhQkQrFuVAiQrFA3KhQpF3gEAjQrFA3KmgB3KsFhQA3gErFjQlgB1KpFjQA7qBrFjQlgB3KrFhQsFhQmgB3K2K3KmgB1K4K3KmgB3KmgBlgBmgB1KuVvVsFhQA9qBrFhQ1K3K3KlgB3K3KpFhQqFjQkQrFuVAkQpF2K3KkQrF8qBAkQrF4K1KiQrFsgCAkQrF2K3KkQpFuVAkQrFuVvVsFhQA9qBrFhQlgB3KrFhQAvVsFhQ4K3KqFhQAhsHpFhQjQrFhQsF3K2KjQsFtVAhQrFA1KuVvVmgB1KuVvVA1K1K3K3KlgB3K3KrFhQAvVpFhQ3K3KrFhQsFjQ4K1C2KkQ"
        }
      ]
    },
    {
      "range": {
        "type": "time",
        "value": 1800
      },
      "polygons": [
        {
          "outer": "BG02u85Csz7jSA6SsFiQ4K4K4KmgB2K2K4KmgB4K4K2KmgB4K4K4KmgBiQqFuVAkQpF4K3KiQrFuVAkQrF2K1KkQrFiQsFsFiQrFkQhQqFtVAjQsF1K4KjQsFtVAjQsFtVuVA4K4K2K2KmgB4KA4K1KmgB3K2K3KmgB1K4K3KiQrFwVAiQrF4K1K2KAsFiQrFkQlgB2K1K4KlgB4K3K2KhQsFvVAhQsFrFiQA-qBsFkQ4K2KqFkQAuVpFkQ3KA3KlgB1KArFiQA-qBsFiQ2K4KsFiQAqrDsFiQ4KA2K1KkQrFuVAiQrF4K3KmgB1K4K3KiQrFkQsFsFkQrFiQlgB4KrFiQA-qBsFiQiQsFwVAiQrF4K1KmgB3K2K3KmgB1K4K3KkQrFuVAiQrF4K1KmgB3K4K3KmgB1K2K3KkQrFuVAkQrF2K1KmgB3K4K3KiQpFwVAiQqFsFkQrFiQlgB4KA4KwVuViQsF-qBAiQrF4K3KiQpFsgCAkQqFA4KjQsFtVAjQsF1K2KjQsF7qBAjQsF1K4KlgB2KrFkQA-qBsFiQ2K4KsFiQAsgCsFkQ4KA2K3KmgB3K4K1KmgB3K2K3KmgB1K4K3KkQrFuVAiQrF4K1KmgB3K-qB9qBsFhQAtVqFjQ4KAsFkQA8qBrFkQlgBmgBrFiQsFkQ4KAmgBlgB2KAsFiQrFkQ1K2KAkQ2KuVsFuVrFkQ1K4KA2K2K4KsFiQrFkQ1K4KA2K2K4KsFiQAwVrFiQ1KAlgBlgBjQrFhQsF3KmgB3K4K1KmgBlgBmgBrFiQsFkQuVuVmgB4KsFiQAwVsFiQ2K4K4KmgB4KAsFjQAtVqFjQkQpFiQqFsFkQrFiQ1K4KrFkQAuVsFiQ01B21BA2KhQsFvVAhQrF3K1KhQrFjQsF3KmgBlgB2KpFkQAuVrFkQlgB2K3K4KlgB4K3K2KhQsFjQrFjgBlgB3KA3K4K1KArFhQA9qBrFjQjQpFtVAhQrF3K3KjQrFl2EAhQsF3KmgBtVuVlgB4K3K4KhQsFjQrF3K3KhQrFtVsFjQkQ3KiQhQsF3gEAjQrF1K3KjQpFtVAhQqF3KmgBjQsFhQrF3K1K1KAxgDygDlgB2K3K4KlgB4KlgBmgBlgB2K9qB-qB1KmgBjQsF7qBAjQrF3K3K1KAlgBmgB3KArFhQsFjQ4K1KsFjQAtVqFjQkQrFiQsF4K4K4KAuVtVsFjQrFhQlgB3K3K3KhQrFjQsFlgBmgB1KArFhQsFjQ2K1K4KlgB4K3K2KlgB4K3KA1KtVvVjQpFrgCAhQrFrFjQArgCsFhQiQrFkQsFsFiQA-qBqFiQkQsFsgCAiQrFsFhQA3gErFjQlgB1KpFjQA7qBrFjQjQrFtVAjQsF1K4KjQsFtVAjQqF1K4KjQsF7qBAjQrFrFhQsFjQkQrFsgCAiQrF4K1KiQrFwVAiQrFsFhQrFjQ3K1KpFjQAtVrFjQvVtVhQrFtVAjQrFA1KmgB3K4K3KiQrFkQsFuVwVsFiQAuVsFkQ2K4KsFiQAuVsFkQ4KA2K3KmgB1K4K3KmgB3KmgBlgBmgB1KuVvVsFhQA9qBrFhQ1K3K3KlgBhQrF9qBAjQsF1K4KjQqF7qBAjQsF3K4KhQsF9qBAhQsF3K2KhQsFjQrFrFhQsFjQkQrF8qBAkQpF2K3KkQrFuVAkQrF2K1KkQrF-qBAiQrF4K3KiQrFsgCAkQpF2K3KkQrF8qBAkQrF4K1KiQrFsgCAkQrF2K3KkQpFuVAkQrFuVvVsFhQA9qBrFhQlgB3KrFhQAvVsFhQ4K3KqFhQAhsHpFhQjQrFhQsF3K2KlgB4K3K4KhQqFvVAhQsF3K4KhQsFvVAhQsF3K2KhQsFvVAhQrFA1KuVvVkQrFuVAkQpF2K3KkQrFuVAkQrF2K1KmgB3K4K3KmgB1KuVvVA1K1K3K3KlgB3K3KrFhQAvVpFhQlgBlgBrFhQAvVrFhQ3K3K1KlgB3K3K3KlgB1K1KrFjQsFhQiQrFkQ2CqFiIAsN"
        }
      ]
    }
  ],
  "notices": [
    {
      "title": "The provided parameter 'departure=2024-10-11T21:23:43%2B02:00' is unknown.",
      "code": "unknownParameter",
      "severity": "info"
    }
  ]
}

This issue should be relatively easy to fix. In addition the departure parameter seems to be unknown.

munterfi commented 1 month ago

Hi @enriquevaa, the changes in #168 address and fix the issue you're experiencing:

library(hereR)
set_verbose(TRUE)
isoline(poi = poi, transport_mode = "pedestrian")
#> Sending 8 request(s) with 1 RPS to: 'https://isoline.router.hereapi.com/v8/isolines?...'
#> Received 8 response(s) with total size: 65.3 Kb
#> Simple feature collection with 48 features and 5 fields
#> Geometry type: POLYGON
#> Dimension:     XY
#> Bounding box:  xmin: 6.118698 ymin: 46.0001 xmax: 9.528837 ymax: 47.59372
#> Geodetic CRS:  WGS 84
#> First 10 features:
#>    id rank           departure             arrival range                       geometry
#> 1   1    1 2024-10-18 17:03:38 2024-10-18 17:08:38   300 POLYGON ((8.27616 47.05015,...
#> 2   1    2 2024-10-18 17:03:38 2024-10-18 17:13:38   600 POLYGON ((8.27204 47.04998,...
#> 3   1    3 2024-10-18 17:03:38 2024-10-18 17:18:38   900 POLYGON ((8.268263 47.04929...
#> 4   1    4 2024-10-18 17:03:38 2024-10-18 17:23:38  1200 POLYGON ((8.265517 47.04998...
#> 5   1    5 2024-10-18 17:03:38 2024-10-18 17:28:38  1500 POLYGON ((8.261054 47.04809...
#> 6   1    6 2024-10-18 17:03:38 2024-10-18 17:33:38  1800 POLYGON ((8.256934 47.04672...
#> 7   2    1 2024-10-18 17:03:38 2024-10-18 17:08:38   300 POLYGON ((8.970358 46.00542...
#> 8   2    2 2024-10-18 17:03:38 2024-10-18 17:13:38   600 POLYGON ((8.966753 46.00594...
#> 9   2    3 2024-10-18 17:03:38 2024-10-18 17:18:38   900 POLYGON ((8.963492 46.00628...
#> 10  2    4 2024-10-18 17:03:38 2024-10-18 17:23:38  1200 POLYGON ((8.9592 46.00594, ...

To install the development version of the package from GitHub use: remotes::install_github("munterfi/hereR")

Please note that it may take some time for the changes to be reflected on CRAN due the (still in 2024? 🐌🐌🐌 ) manual release process.

munterfi / hereR

Bug: Pedestrian doesn´t work in isoline #167