search

muntorg / munt-official

Munt is a witness-secured decentralized network for payments, digital assets, finance and more
https://www.munt.org
Other
135 stars 46 forks source link

Fixed double bdb preprocessor renaming #194

Closed timkoers closed 4 years ago

timkoers commented 4 years ago

Fixed permission denied whilest renaming dbinc/atomic.h to dbinc/atomic.h.old, because the renaming process was already done.

mjmacleod commented 4 years ago

Thanks for the pull request.

Unfortunately the request is failing/breaking on our travis CI build, as it appears with the change you have made one of the substitutions that needs to occur doesn't occur.

If you can rework your fix in a slightly different way and push the change I can accept it. The easiest way I can think would be to simply use a different extension for the second sed call (e.g. .old2 of .old) to prevent using the same name twice.

timkoers commented 4 years ago

I've updated the commit. Please let me know if you agree with the changes!

mjmacleod commented 4 years ago

Changes seem to make sense now, and no longer fail the travis build. Will merge, thank you for your contribution.